core/fpdfdoc/doc_formcontrol.cpp - Issue 1846083002: Remove CFX_{Byte,Wide}String::Equal in favor of "==".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfdoc/doc_formcontrol.cpp

Issue 1846083002: Remove CFX_{Byte,Wide}String::Equal in favor of "==". (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Nits. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfdoc/doc_formcontrol.cpp

diff --git a/core/fpdfdoc/doc_formcontrol.cpp b/core/fpdfdoc/doc_formcontrol.cpp

index 255b5e9a703fbad5b59b608c4fd2b1c5f9ead6f9..1fcc4a386b8b0741ed73cdf49a9010a3bdadb8b8 100644

--- a/core/fpdfdoc/doc_formcontrol.cpp

+++ b/core/fpdfdoc/doc_formcontrol.cpp

@@ -190,7 +190,7 @@ CPDF_FormControl::HighlightingMode CPDF_FormControl::GetHighlightingMode() {

}

CFX_ByteString csH = m_pWidgetDict->GetStringBy("H", "I");

for (int i = 0; g_sHighlightingMode[i]; ++i) {

- if (csH.Equal(g_sHighlightingMode[i]))

+ if (csH == g_sHighlightingMode[i])

return static_cast<HighlightingMode>(i);

}

return Invert;

« no previous file with comments | « core/fpdfdoc/doc_basic_unittest.cpp ('k') | core/fxcrt/fx_basic_bstring.cpp » ('j') | no next file with comments »