xfa/fxfa/app/xfa_ffdoc.cpp - Issue 1846083002: Remove CFX_{Byte,Wide}String::Equal in favor of "==".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/app/xfa_ffdoc.cpp

Issue 1846083002: Remove CFX_{Byte,Wide}String::Equal in favor of "==". (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Nits. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxfa/app/xfa_ffdoc.cpp

diff --git a/xfa/fxfa/app/xfa_ffdoc.cpp b/xfa/fxfa/app/xfa_ffdoc.cpp

index 94f035251e31ed79e6ebc488c6aa5eea36c477bd..ed4f94cd77bda941761482b40fb6d1538fd01aa3 100644

--- a/xfa/fxfa/app/xfa_ffdoc.cpp

+++ b/xfa/fxfa/app/xfa_ffdoc.cpp

@@ -59,7 +59,7 @@ FX_BOOL XFA_GetPDFContentsFromPDFXML(CFDE_XMLNode* pPDFElement,

CFX_WideString wsTagName;

CFDE_XMLElement* pXMLElement = static_cast<CFDE_XMLElement*>(pXMLNode);

pXMLElement->GetTagName(wsTagName);

- if (wsTagName.Equal(FX_WSTRC(L"document"))) {

+ if (wsTagName == FX_WSTRC(L"document")) {

pDocumentElement = pXMLElement;

break;

}

@@ -76,7 +76,7 @@ FX_BOOL XFA_GetPDFContentsFromPDFXML(CFDE_XMLNode* pPDFElement,

CFX_WideString wsTagName;

CFDE_XMLElement* pXMLElement = static_cast<CFDE_XMLElement*>(pXMLNode);

pXMLElement->GetTagName(wsTagName);

- if (wsTagName.Equal(FX_WSTRC(L"chunk"))) {

+ if (wsTagName == FX_WSTRC(L"chunk")) {

pChunkElement = pXMLElement;

break;

}

« no previous file with comments | « xfa/fwl/basewidget/fwl_comboboximp.cpp ('k') | xfa/fxfa/app/xfa_ffwidgetacc.cpp » ('j') | no next file with comments »