String replaceWithLiteral should just use strlen, also rename to replace.

String replaceWithLiteral should just use strlen, also rename to replace.

The compiler will turn strlen on a literal into an integer, we don't need to use
template magic for it. This also allows replace('x', kConstant) where kConstant
is a literal string to get optimized by the compiler. Previously you'd need to
call replace(UChar a, const String& b) which did a String allocation on the
kConstant to execute the replace.

Committed: https://crrev.com/ff8330c67efc3469abb1d83dc5bf5bb59bbaed97
Cr-Commit-Position: refs/heads/master@{#384513}

[esprehn, 2016-03-31 18:35:53]

Description was changed from

==========
String replaceWithLiteral should just use strlen.

BUG=
==========

to

==========
String replaceWithLiteral should just use strlen, also rename to replace.

The compiler will turn strlen on a literal into an integer, we don't need to use
template magic for it. This also allows replace('x', kConstant) where kConstant
is a literal string to get optimized by the compiler. Previously you'd need to
call replace(UChar a, const String& b) which did a String allocation on the 
kConstant to execute the replace.
==========

[esprehn, 2016-03-31 18:35:57]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-31 18:36:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845363003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845363003/1

[esprehn, 2016-03-31 18:38:01]

The CQ bit was unchecked by esprehn@chromium.org

[esprehn, 2016-03-31 18:39:36]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-31 18:40:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845363003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845363003/20001

[commit-bot: I haz the power, 2016-03-31 18:58:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 18:58:33]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[esprehn, 2016-03-31 21:46:33]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-31 21:47:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845363003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845363003/40001

[commit-bot: I haz the power, 2016-03-31 22:02:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 22:02:01]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[esprehn, 2016-04-01 00:09:23]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-01 00:09:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845363003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845363003/60001

[esprehn, 2016-04-01 04:39:57]

esprehn@chromium.org changed reviewers:
+ haraken@chromium.org, jyasskin@chromium.org, yutak@chromium.org

[haraken, 2016-04-01 04:41:18]

LGTM

[esprehn, 2016-04-01 04:51:01]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2016-04-01 04:51:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845363003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845363003/60001

[Yuta Kitamura, 2016-04-01 05:48:00]

lgtm

[commit-bot: I haz the power, 2016-04-01 06:11:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-01 06:11:59]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[esprehn, 2016-04-01 07:05:08]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2016-04-01 07:05:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845363003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845363003/60001

[commit-bot: I haz the power, 2016-04-01 07:58:39]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-01 08:00:00]

Description was changed from

==========
String replaceWithLiteral should just use strlen, also rename to replace.

The compiler will turn strlen on a literal into an integer, we don't need to use
template magic for it. This also allows replace('x', kConstant) where kConstant
is a literal string to get optimized by the compiler. Previously you'd need to
call replace(UChar a, const String& b) which did a String allocation on the 
kConstant to execute the replace.
==========

to

==========
String replaceWithLiteral should just use strlen, also rename to replace.

The compiler will turn strlen on a literal into an integer, we don't need to use
template magic for it. This also allows replace('x', kConstant) where kConstant
is a literal string to get optimized by the compiler. Previously you'd need to
call replace(UChar a, const String& b) which did a String allocation on the
kConstant to execute the replace.

Committed: https://crrev.com/ff8330c67efc3469abb1d83dc5bf5bb59bbaed97
Cr-Commit-Position: refs/heads/master@{#384513}
==========

[commit-bot: I haz the power, 2016-04-01 08:00:02]

Patchset 4 (id:??) landed as
https://crrev.com/ff8330c67efc3469abb1d83dc5bf5bb59bbaed97
Cr-Commit-Position: refs/heads/master@{#384513}