third_party/WebKit/Source/wtf/text/WTFString.h - Issue 1845363003: String replaceWithLiteral should just use strlen, also rename to replace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/WTFString.h

Issue 1845363003: String replaceWithLiteral should just use strlen, also rename to replace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Another NUL fix. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/text/UnicodeUtilities.cpp ('k') | third_party/WebKit/Source/wtf/text/WTFStringTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/wtf/text/WTFString.h

diff --git a/third_party/WebKit/Source/wtf/text/WTFString.h b/third_party/WebKit/Source/wtf/text/WTFString.h

index 8d7ead9dbf1dcbf37e0c9666c22cb51f544a60ba..356f4287acd2e039d544fe529a86dc5dc1331654 100644

--- a/third_party/WebKit/Source/wtf/text/WTFString.h

+++ b/third_party/WebKit/Source/wtf/text/WTFString.h

@@ -320,12 +320,11 @@ public:

return *this;

}

- template<unsigned charactersCount>

- ALWAYS_INLINE String& replaceWithLiteral(UChar a, const char (&characters)[charactersCount])

+ ALWAYS_INLINE String& replace(UChar a, const char* characters)

{

+ ASSERT(characters);

if (m_impl)

- m_impl = m_impl->replace(a, characters, charactersCount - 1);

+ m_impl = m_impl->replace(a, characters, strlen(characters));

return *this;

}