third_party/WebKit/Source/core/editing/serializers/MarkupFormatter.cpp - Issue 1845363003: String replaceWithLiteral should just use strlen, also rename to replace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/serializers/MarkupFormatter.cpp

Issue 1845363003: String replaceWithLiteral should just use strlen, also rename to replace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Another NUL fix. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/EditingStyle.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/serializers/MarkupFormatter.cpp

diff --git a/third_party/WebKit/Source/core/editing/serializers/MarkupFormatter.cpp b/third_party/WebKit/Source/core/editing/serializers/MarkupFormatter.cpp

index 8622985114fe9df6c703596c079866b1e0a376a7..a16bdc05e5f3ffdca1b187270fd2b7d5620193dc 100644

--- a/third_party/WebKit/Source/core/editing/serializers/MarkupFormatter.cpp

+++ b/third_party/WebKit/Source/core/editing/serializers/MarkupFormatter.cpp

@@ -198,11 +198,11 @@ void MarkupFormatter::appendQuotedURLAttributeValue(StringBuilder& result, const

if (protocolIsJavaScript(strippedURLString)) {

// minimal escaping for javascript urls

if (strippedURLString.contains('&'))

- strippedURLString.replaceWithLiteral('&', "&");

+ strippedURLString.replace('&', "&");

if (strippedURLString.contains('"')) {

if (strippedURLString.contains('\''))

- strippedURLString.replaceWithLiteral('"', """);

+ strippedURLString.replace('"', """);

else

quoteChar = '\'';

}