Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp

Issue 1845363003: String replaceWithLiteral should just use strlen, also rename to replace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Another NUL fix. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * (C) 1999 Lars Knoll (knoll@kde.org) 2 * (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Dirk Mueller (mueller@kde.org) 3 * (C) 2000 Dirk Mueller (mueller@kde.org)
4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 599 matching lines...) Expand 10 before | Expand all | Expand 10 after
610 String InlineTextBox::text() const 610 String InlineTextBox::text() const
611 { 611 {
612 return getLineLayoutItem().text().substring(start(), len()); 612 return getLineLayoutItem().text().substring(start(), len());
613 } 613 }
614 614
615 #ifndef NDEBUG 615 #ifndef NDEBUG
616 616
617 void InlineTextBox::showBox(int printedCharacters) const 617 void InlineTextBox::showBox(int printedCharacters) const
618 { 618 {
619 String value = text(); 619 String value = text();
620 value.replaceWithLiteral('\\', "\\\\"); 620 value.replace('\\', "\\\\");
621 value.replaceWithLiteral('\n', "\\n"); 621 value.replace('\n', "\\n");
622 printedCharacters += fprintf(stderr, "%s %p", boxName(), this); 622 printedCharacters += fprintf(stderr, "%s %p", boxName(), this);
623 for (; printedCharacters < showTreeCharacterOffset; printedCharacters++) 623 for (; printedCharacters < showTreeCharacterOffset; printedCharacters++)
624 fputc(' ', stderr); 624 fputc(' ', stderr);
625 const LineLayoutText obj = getLineLayoutItem(); 625 const LineLayoutText obj = getLineLayoutItem();
626 printedCharacters = fprintf(stderr, "\t%s %p", obj.name(), obj.debugPointer( )); 626 printedCharacters = fprintf(stderr, "\t%s %p", obj.name(), obj.debugPointer( ));
627 const int layoutObjectCharacterOffset = 75; 627 const int layoutObjectCharacterOffset = 75;
628 for (; printedCharacters < layoutObjectCharacterOffset; printedCharacters++) 628 for (; printedCharacters < layoutObjectCharacterOffset; printedCharacters++)
629 fputc(' ', stderr); 629 fputc(' ', stderr);
630 fprintf(stderr, "(%d,%d) \"%s\"\n", start(), start() + len(), value.utf8().d ata()); 630 fprintf(stderr, "(%d,%d) \"%s\"\n", start(), start() + len(), value.utf8().d ata());
631 } 631 }
632 632
633 #endif 633 #endif
634 634
635 } // namespace blink 635 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp ('k') | third_party/WebKit/Source/core/loader/FormSubmission.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698