String replaceWithLiteral should just use strlen, also rename to replace.

third_party/WebKit/Source/platform/text/UnicodeUtilities.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2005 Alexey Proskuryakov.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 59 matching lines @@
 void foldQuoteMarksAndSoftHyphens(String& s)
 {
     s.replace(hebrewPunctuationGereshCharacter, '\'');
     s.replace(hebrewPunctuationGershayimCharacter, '"');
     s.replace(leftDoubleQuotationMarkCharacter, '"');
     s.replace(leftSingleQuotationMarkCharacter, '\'');
     s.replace(rightDoubleQuotationMarkCharacter, '"');
     s.replace(rightSingleQuotationMarkCharacter, '\'');
     // Replace soft hyphen with an ignorable character so that their presence or absence will
     // not affect string comparison.
-    s.replace(softHyphenCharacter, 0);
+    s.replace(softHyphenCharacter, static_cast<UChar>('\0'));
 }
 
 static bool isNonLatin1Separator(UChar32 character)
 {
     DCHECK_GE(character, 256);
     return U_GET_GC_MASK(character) & (U_GC_S_MASK | U_GC_P_MASK | U_GC_Z_MASK | U_GC_CF_MASK);
 }
 
 bool isSeparator(UChar32 character)
 {
@@ skipping 313 matching lines @@
         if (offset == kNotFound)
             return false;
 
         // Update values of |a| and |b| after comparing.
         a += offset;
         b += offset;
     }
 }
 
 } // namespace blink