third_party/WebKit/Source/platform/text/LocaleWinTest.cpp - Issue 1845363003: String replaceWithLiteral should just use strlen, also rename to replace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/text/LocaleWinTest.cpp

Issue 1845363003: String replaceWithLiteral should just use strlen, also rename to replace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Another NUL fix. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/xml/XSLTProcessor.cpp ('k') | third_party/WebKit/Source/platform/text/UnicodeUtilities.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/text/LocaleWinTest.cpp

diff --git a/third_party/WebKit/Source/platform/text/LocaleWinTest.cpp b/third_party/WebKit/Source/platform/text/LocaleWinTest.cpp

index 7309b178f9d44bcb2f0a3782edad6c34a9d2c502..a4ebc278068afff3f398db77450945c7d3f6d0b7 100644

--- a/third_party/WebKit/Source/platform/text/LocaleWinTest.cpp

+++ b/third_party/WebKit/Source/platform/text/LocaleWinTest.cpp

@@ -215,7 +215,7 @@ TEST_F(LocaleWinTest, monthFormat)

// Month format for EnglishUS:

// "MMMM, yyyy" on Windows 7 or older.

// "MMMM yyyy" on Window 8 or later.

- EXPECT_STREQ("MMMM yyyy", monthFormat(EnglishUS).replaceWithLiteral(',', "").utf8().data());

+ EXPECT_STREQ("MMMM yyyy", monthFormat(EnglishUS).replace(',', "").utf8().data());

EXPECT_STREQ("MMMM yyyy", monthFormat(FrenchFR).utf8().data());

EXPECT_STREQ("yyyy\xE5\xB9\xB4M\xE6\x9C\x88", monthFormat(JapaneseJP).utf8().data());

}