third_party/WebKit/Source/core/xml/XSLTProcessor.cpp - Issue 1845363003: String replaceWithLiteral should just use strlen, also rename to replace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/xml/XSLTProcessor.cpp

Issue 1845363003: String replaceWithLiteral should just use strlen, also rename to replace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Another NUL fix. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/loader/FormSubmission.cpp ('k') | third_party/WebKit/Source/platform/text/LocaleWinTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/xml/XSLTProcessor.cpp

diff --git a/third_party/WebKit/Source/core/xml/XSLTProcessor.cpp b/third_party/WebKit/Source/core/xml/XSLTProcessor.cpp

index 774add4619cc1c3f6d18cae2ff0d35e21ceb2165..6fd204ec1e065e441bcd18cd25c255801724f1a9 100644

--- a/third_party/WebKit/Source/core/xml/XSLTProcessor.cpp

+++ b/third_party/WebKit/Source/core/xml/XSLTProcessor.cpp

@@ -40,8 +40,8 @@ namespace blink {

static inline void transformTextStringToXHTMLDocumentString(String& text)

{

// Modify the output so that it is a well-formed XHTML document with a <pre> tag enclosing the text.

- text.replaceWithLiteral('&', "&");

- text.replaceWithLiteral('<', "<");

+ text.replace('&', "&");

+ text.replace('<', "<");

text = "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n"

"<!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.0 Strict//EN\" \"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd\">\n"

"<html xmlns=\"http://www.w3.org/1999/xhtml\">\n"