Reduce signed/unsigned comparison warnings

Reduce signed/unsigned comparison warnings

The warnings generated by Clang. This is part 1 for some simple cases.

BUG=pdfium:29
R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/8940993efffaaf432320509555dc61122b8b72b2

[Wei Li, 2016-03-25 22:18:00]

weili@chromium.org changed reviewers:
+ tsepez@chromium.org

[Wei Li, 2016-03-25 22:18:01]

PTAL, thanks

[Tom Sepez, 2016-03-25 22:31:41]

https://codereview.chromium.org/1840483003/diff/1/core/fpdfapi/fpdf_page/cpdf...
File core/fpdfapi/fpdf_page/cpdf_colorspace.cpp (right):

https://codereview.chromium.org/1840483003/diff/1/core/fpdfapi/fpdf_page/cpdf...
core/fpdfapi/fpdf_page/cpdf_colorspace.cpp:493: for (size_t j = 0; j <
m_nComponents; j++)
nit: probaby should be uint32_t to match m_nComponents.  But I'm not sure how I
feel about the mismatch.  It may even be a good thing to avoid changes should
m_nComponents become a size_t.  Hmmm.

https://codereview.chromium.org/1840483003/diff/1/core/fpdfapi/fpdf_parser/cp...
File core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp (right):

https://codereview.chromium.org/1840483003/diff/1/core/fpdfapi/fpdf_parser/cp...
core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp:188: for (size_t j = 0; j <
m_dwNSharedObjsArray[i]; j++)
This one should be an uint32_t, though.  Its an array of them, and we're using
an element, not some abstract notion of size.  Also below.

https://codereview.chromium.org/1840483003/diff/1/core/fxcodec/jbig2/JBig2_Co...
File core/fxcodec/jbig2/JBig2_Context.cpp (right):

https://codereview.chromium.org/1840483003/diff/1/core/fxcodec/jbig2/JBig2_Co...
core/fxcodec/jbig2/JBig2_Context.cpp:1302: if (nBits == runcodes_len[j] && nVal
== runcodes[j]) {
nit: no inner {}

https://codereview.chromium.org/1840483003/diff/1/core/fxcodec/jbig2/JBig2_Co...
core/fxcodec/jbig2/JBig2_Context.cpp:1306: if (j < kRunCodesSize) {
nit: no {} needed.

https://codereview.chromium.org/1840483003/diff/1/core/fxcodec/jbig2/JBig2_Co...
core/fxcodec/jbig2/JBig2_Context.cpp:1310: int32_t runcode = j;
This may require a cast to avoid a truncation warning?

https://codereview.chromium.org/1840483003/diff/1/core/fxcrt/include/fx_ext.h
File core/fxcrt/include/fx_ext.h (right):

https://codereview.chromium.org/1840483003/diff/1/core/fxcrt/include/fx_ext.h...
core/fxcrt/include/fx_ext.h:15: #define FX_INVALID_OFFSET
(static_cast<FX_DWORD>(-1))
nit: outer parens not needed.

https://codereview.chromium.org/1840483003/diff/1/fpdfsdk/pdfwindow/PWL_FontM...
File fpdfsdk/pdfwindow/PWL_FontMap.cpp (right):

https://codereview.chromium.org/1840483003/diff/1/fpdfsdk/pdfwindow/PWL_FontM...
fpdfsdk/pdfwindow/PWL_FontMap.cpp:180: for (size_t i = 0; i <
FX_ArraySize(g_sDEStandardFontName); ++i) {
good.  this one is a size_t for sure.

[Wei Li, 2016-03-26 01:04:10]

https://codereview.chromium.org/1840483003/diff/1/core/fpdfapi/fpdf_page/cpdf...
File core/fpdfapi/fpdf_page/cpdf_colorspace.cpp (right):

https://codereview.chromium.org/1840483003/diff/1/core/fpdfapi/fpdf_page/cpdf...
core/fpdfapi/fpdf_page/cpdf_colorspace.cpp:493: for (size_t j = 0; j <
m_nComponents; j++)
On 2016/03/25 22:31:40, Tom Sepez wrote:
> nit: probaby should be uint32_t to match m_nComponents.  But I'm not sure how
I
> feel about the mismatch.  It may even be a good thing to avoid changes should
> m_nComponents become a size_t.  Hmmm.

I feel fixed width integers may not be needed in these cases, but size_t seems
to be an overkill in term of size. I am leaning towards 'unsigned int' which is
a bit long to write. :(

Changed to be consistent with current type.

https://codereview.chromium.org/1840483003/diff/1/core/fpdfapi/fpdf_parser/cp...
File core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp (right):

https://codereview.chromium.org/1840483003/diff/1/core/fpdfapi/fpdf_parser/cp...
core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp:188: for (size_t j = 0; j <
m_dwNSharedObjsArray[i]; j++)
On 2016/03/25 22:31:40, Tom Sepez wrote:
> This one should be an uint32_t, though.  Its an array of them, and we're using
> an element, not some abstract notion of size.  Also below.

Done.

https://codereview.chromium.org/1840483003/diff/1/core/fxcodec/jbig2/JBig2_Co...
File core/fxcodec/jbig2/JBig2_Context.cpp (right):

https://codereview.chromium.org/1840483003/diff/1/core/fxcodec/jbig2/JBig2_Co...
core/fxcodec/jbig2/JBig2_Context.cpp:1302: if (nBits == runcodes_len[j] && nVal
== runcodes[j]) {
On 2016/03/25 22:31:40, Tom Sepez wrote:
> nit: no inner {}

Done.

https://codereview.chromium.org/1840483003/diff/1/core/fxcodec/jbig2/JBig2_Co...
core/fxcodec/jbig2/JBig2_Context.cpp:1306: if (j < kRunCodesSize) {
On 2016/03/25 22:31:40, Tom Sepez wrote:
> nit: no {} needed.

Done.

https://codereview.chromium.org/1840483003/diff/1/core/fxcodec/jbig2/JBig2_Co...
core/fxcodec/jbig2/JBig2_Context.cpp:1310: int32_t runcode = j;
On 2016/03/25 22:31:40, Tom Sepez wrote:
> This may require a cast to avoid a truncation warning?

Done.

https://codereview.chromium.org/1840483003/diff/1/core/fxcrt/include/fx_ext.h
File core/fxcrt/include/fx_ext.h (right):

https://codereview.chromium.org/1840483003/diff/1/core/fxcrt/include/fx_ext.h...
core/fxcrt/include/fx_ext.h:15: #define FX_INVALID_OFFSET
(static_cast<FX_DWORD>(-1))
On 2016/03/25 22:31:40, Tom Sepez wrote:
> nit: outer parens not needed.

Done.

https://codereview.chromium.org/1840483003/diff/1/fpdfsdk/pdfwindow/PWL_FontM...
File fpdfsdk/pdfwindow/PWL_FontMap.cpp (right):

https://codereview.chromium.org/1840483003/diff/1/fpdfsdk/pdfwindow/PWL_FontM...
fpdfsdk/pdfwindow/PWL_FontMap.cpp:180: for (size_t i = 0; i <
FX_ArraySize(g_sDEStandardFontName); ++i) {
On 2016/03/25 22:31:41, Tom Sepez wrote:
> good.  this one is a size_t for sure.

Acknowledged.

[Tom Sepez, 2016-03-26 02:37:57]

lgtm

[Wei Li, 2016-03-28 17:11:45]

Patchset #3 (id:40001) has been deleted

[Wei Li, 2016-03-28 17:33:38]

Description was changed from

==========
Reduce signed/unsigned comparison warnings

The warnings generated by Clang. This is part 1 for some simple cases.

BUG=pdfium:29
==========

to

==========
Reduce signed/unsigned comparison warnings

The warnings generated by Clang. This is part 1 for some simple cases.

BUG=pdfium:29
R=tsepez@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/8940993efffaaf432320509555dc61122b8b...
==========

[Wei Li, 2016-03-28 17:33:40]

Committed patchset #3 (id:60001) manually as
8940993efffaaf432320509555dc61122b8b72b2 (presubmit successful).