Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: fpdfsdk/fxedit/fxet_edit.cpp

Issue 1840483003: Reduce signed/unsigned comparison warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « fpdfsdk/fsdk_baseform.cpp ('k') | fpdfsdk/javascript/Document.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "fpdfsdk/include/fxedit/fxet_edit.h" 7 #include "fpdfsdk/include/fxedit/fxet_edit.h"
8 8
9 #include <algorithm> 9 #include <algorithm>
10 10
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 uint16_t word, 103 uint16_t word,
104 int32_t nWordStyle) { 104 int32_t nWordStyle) {
105 if (CPDF_Font* pPDFFont = m_pFontMap->GetPDFFont(nFontIndex)) { 105 if (CPDF_Font* pPDFFont = m_pFontMap->GetPDFFont(nFontIndex)) {
106 uint32_t charcode = word; 106 uint32_t charcode = word;
107 107
108 if (pPDFFont->IsUnicodeCompatible()) 108 if (pPDFFont->IsUnicodeCompatible())
109 charcode = pPDFFont->CharCodeFromUnicode(word); 109 charcode = pPDFFont->CharCodeFromUnicode(word);
110 else 110 else
111 charcode = m_pFontMap->CharCodeFromUnicode(nFontIndex, word); 111 charcode = m_pFontMap->CharCodeFromUnicode(nFontIndex, word);
112 112
113 if (charcode != -1) 113 if (charcode != CPDF_Font::kInvalidCharCode)
114 return pPDFFont->GetCharWidthF(charcode); 114 return pPDFFont->GetCharWidthF(charcode);
115 } 115 }
116 116
117 return 0; 117 return 0;
118 } 118 }
119 119
120 int32_t CFX_Edit_Provider::GetTypeAscent(int32_t nFontIndex) { 120 int32_t CFX_Edit_Provider::GetTypeAscent(int32_t nFontIndex) {
121 if (CPDF_Font* pPDFFont = m_pFontMap->GetPDFFont(nFontIndex)) 121 if (CPDF_Font* pPDFFont = m_pFontMap->GetPDFFont(nFontIndex))
122 return pPDFFont->GetTypeAscent(); 122 return pPDFFont->GetTypeAscent();
123 123
(...skipping 2901 matching lines...) Expand 10 before | Expand all | Expand 10 after
3025 if (m_bOprNotify && m_pOprNotify) 3025 if (m_bOprNotify && m_pOprNotify)
3026 m_pOprNotify->OnAddUndo(pEditUndoItem); 3026 m_pOprNotify->OnAddUndo(pEditUndoItem);
3027 } 3027 }
3028 } 3028 }
3029 3029
3030 void CFX_Edit::AddUndoItem(IFX_Edit_UndoItem* pUndoItem) { 3030 void CFX_Edit::AddUndoItem(IFX_Edit_UndoItem* pUndoItem) {
3031 m_Undo.AddItem(pUndoItem); 3031 m_Undo.AddItem(pUndoItem);
3032 if (m_bOprNotify && m_pOprNotify) 3032 if (m_bOprNotify && m_pOprNotify)
3033 m_pOprNotify->OnAddUndo(pUndoItem); 3033 m_pOprNotify->OnAddUndo(pUndoItem);
3034 } 3034 }
OLDNEW
« no previous file with comments | « fpdfsdk/fsdk_baseform.cpp ('k') | fpdfsdk/javascript/Document.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698