fpdfsdk/fxedit/fxet_edit.cpp - Issue 1840483003: Reduce signed/unsigned comparison warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/fxedit/fxet_edit.cpp

Issue 1840483003: Reduce signed/unsigned comparison warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/fxedit/fxet_edit.cpp

diff --git a/fpdfsdk/fxedit/fxet_edit.cpp b/fpdfsdk/fxedit/fxet_edit.cpp

index 3d7e485f356fb0534e8f68b08230750aa032614f..f45f9ea5f242c2a8a45b9d66a98077edababeeb6 100644

--- a/fpdfsdk/fxedit/fxet_edit.cpp

+++ b/fpdfsdk/fxedit/fxet_edit.cpp

@@ -110,7 +110,7 @@ int32_t CFX_Edit_Provider::GetCharWidth(int32_t nFontIndex,

else

charcode = m_pFontMap->CharCodeFromUnicode(nFontIndex, word);

- if (charcode != -1)

+ if (charcode != CPDF_Font::kInvalidCharCode)

return pPDFFont->GetCharWidthF(charcode);

}

« no previous file with comments | « fpdfsdk/fsdk_baseform.cpp ('k') | fpdfsdk/javascript/Document.cpp » ('j') | no next file with comments »