core/fxge/ge/fx_ge_font.cpp - Issue 1840483003: Reduce signed/unsigned comparison warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxge/ge/fx_ge_font.cpp

Issue 1840483003: Reduce signed/unsigned comparison warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxge/ge/fx_ge_font.cpp

diff --git a/core/fxge/ge/fx_ge_font.cpp b/core/fxge/ge/fx_ge_font.cpp

index 04019a059cd8a63bc6fa0bbb1c09cb8187f057c7..fab5ea28a9dde029e484195c31f0ad4d570f375a 100644

--- a/core/fxge/ge/fx_ge_font.cpp

+++ b/core/fxge/ge/fx_ge_font.cpp

@@ -4,6 +4,7 @@

+#include "core/fpdfapi/fpdf_font/include/cpdf_font.h"

#include "core/fxge/ge/fx_text_int.h"

#include "core/include/fxge/fx_freetype.h"

#include "core/include/fxge/fx_ge.h"

@@ -516,7 +517,7 @@ uint32_t CFX_UnicodeEncodingEx::CharCodeFromUnicode(FX_WCHAR Unicode) const {

return Unicode;

}

- return static_cast<uint32_t>(-1);

+ return CPDF_Font::kInvalidCharCode;

}

CFX_UnicodeEncodingEx* FX_CreateFontEncodingEx(CFX_Font* pFont,

« no previous file with comments | « core/fxcrt/include/fx_ext.h ('k') | core/fxge/ge/fx_ge_fontmap.cpp » ('j') | no next file with comments »