fpdfsdk/javascript/Document.cpp - Issue 1840483003: Reduce signed/unsigned comparison warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/javascript/Document.cpp

Issue 1840483003: Reduce signed/unsigned comparison warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/javascript/Document.cpp

diff --git a/fpdfsdk/javascript/Document.cpp b/fpdfsdk/javascript/Document.cpp

index 0b793db0497aa1748a33fbecb9ef606f4607a3cc..70b4ef7e032eacc936816088d9efccc0175972cc 100644

--- a/fpdfsdk/javascript/Document.cpp

+++ b/fpdfsdk/javascript/Document.cpp

@@ -1460,7 +1460,7 @@ int Document::CountWords(CPDF_TextObject* pTextObj) {

FX_BOOL bIsLatin = FALSE;

for (int i = 0, sz = pTextObj->CountChars(); i < sz; i++) {

- uint32_t charcode = static_cast<uint32_t>(-1);

+ uint32_t charcode = CPDF_Font::kInvalidCharCode;

FX_FLOAT kerning;

pTextObj->GetCharInfo(i, charcode, kerning);