core/fpdfapi/fpdf_parser/cpdf_array.cpp - Issue 1840483003: Reduce signed/unsigned comparison warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/cpdf_array.cpp

Issue 1840483003: Reduce signed/unsigned comparison warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_parser/cpdf_array.cpp

diff --git a/core/fpdfapi/fpdf_parser/cpdf_array.cpp b/core/fpdfapi/fpdf_parser/cpdf_array.cpp

index 69de5bbc26f41fc67a3d435573c951efb6919d78..544469916beba0a6f5867e9cd7837a0622939de2 100644

--- a/core/fpdfapi/fpdf_parser/cpdf_array.cpp

+++ b/core/fpdfapi/fpdf_parser/cpdf_array.cpp

@@ -47,7 +47,7 @@ const CPDF_Array* CPDF_Array::AsArray() const {

CPDF_Object* CPDF_Array::Clone(FX_BOOL bDirect) const {

CPDF_Array* pCopy = new CPDF_Array();

- for (int i = 0; i < GetCount(); i++) {

+ for (size_t i = 0; i < GetCount(); i++) {

CPDF_Object* value = m_Objects.GetAt(i);

pCopy->m_Objects.Add(value->Clone(bDirect));

}