Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: core/fxcrt/include/fx_ext.h

Issue 1840483003: Reduce signed/unsigned comparison warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/fxcodec/jbig2/JBig2_Context.cpp ('k') | core/fxge/ge/fx_ge_font.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #ifndef CORE_FXCRT_INCLUDE_FX_EXT_H_ 7 #ifndef CORE_FXCRT_INCLUDE_FX_EXT_H_
8 #define CORE_FXCRT_INCLUDE_FX_EXT_H_ 8 #define CORE_FXCRT_INCLUDE_FX_EXT_H_
9 9
10 #include <cctype> 10 #include <cctype>
11 #include <cwctype> 11 #include <cwctype>
12 12
13 #include "core/fxcrt/include/fx_basic.h" 13 #include "core/fxcrt/include/fx_basic.h"
14 14
15 #define FX_INVALID_OFFSET static_cast<uint32_t>(-1)
16
15 // TODO(thestig) Using unique_ptr with ReleaseDeleter is still not ideal. 17 // TODO(thestig) Using unique_ptr with ReleaseDeleter is still not ideal.
16 // Come up or wait for something better. This appears in this file rather 18 // Come up or wait for something better. This appears in this file rather
17 // than fx_stream.h due to include ordering restrictions. 19 // than fx_stream.h due to include ordering restrictions.
18 using ScopedFileStream = 20 using ScopedFileStream =
19 std::unique_ptr<IFX_FileStream, ReleaseDeleter<IFX_FileStream>>; 21 std::unique_ptr<IFX_FileStream, ReleaseDeleter<IFX_FileStream>>;
20 22
21 FX_FLOAT FXSYS_tan(FX_FLOAT a); 23 FX_FLOAT FXSYS_tan(FX_FLOAT a);
22 FX_FLOAT FXSYS_logb(FX_FLOAT b, FX_FLOAT x); 24 FX_FLOAT FXSYS_logb(FX_FLOAT b, FX_FLOAT x);
23 FX_FLOAT FXSYS_strtof(const FX_CHAR* pcsStr, 25 FX_FLOAT FXSYS_strtof(const FX_CHAR* pcsStr,
24 int32_t iLength = -1, 26 int32_t iLength = -1,
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 j -= gap; 127 j -= gap;
126 } 128 }
127 pArray[j + gap] = v1; 129 pArray[j + gap] = v1;
128 } 130 }
129 gap >>= 1; 131 gap >>= 1;
130 } 132 }
131 } 133 }
132 }; 134 };
133 135
134 #endif // CORE_FXCRT_INCLUDE_FX_EXT_H_ 136 #endif // CORE_FXCRT_INCLUDE_FX_EXT_H_
OLDNEW
« no previous file with comments | « core/fxcodec/jbig2/JBig2_Context.cpp ('k') | core/fxge/ge/fx_ge_font.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698