Use sk_sp-based shader creation APIs

Use sk_sp-based shader creation APIs

Favor Skia's smart pointer based interface over raw pointers.
Switch Chrome (but not Blink) to sk_sp<SkShader> params
where feasible.

BUG=skia:5077, 597620
R=fmalita@chromium.org,danakj@chromium.org,sky@chromium.org
TBR=estade@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/2b45cf96adcc9d4902f926d9fd3ae17fb09d884e
Cr-Commit-Position: refs/heads/master@{#384266}

[tomhudson, 2016-03-24 18:39:11]

Description was changed from

==========
Use sk_sp-based shader creation APIs

Favor Skia's smart pointer based interface over raw pointers.
Switch Chrome (but not Blink) to sk_sp<SkShader> params
where feasible.

BUG=skia:5077,597620
R=fmalita@chromium.org
==========

to

==========
Use sk_sp-based shader creation APIs

Favor Skia's smart pointer based interface over raw pointers.
Switch Chrome (but not Blink) to sk_sp<SkShader> params
where feasible.

BUG=skia:5077,597620
R=fmalita@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[tomhudson, 2016-03-24 18:40:08]

The CQ bit was checked by tomhudson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-24 18:40:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1831883002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1831883002/1

[commit-bot: I haz the power, 2016-03-24 19:03:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 19:04:00]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tomhudson, 2016-03-25 16:23:16]

tomhudson@google.com changed reviewers:
+ danakj@chromium.org

[tomhudson, 2016-03-25 16:23:17]

We need to *undo* the SkUserConfig change before committing, since Mike reused
that flag in another CL, but I want to leave it in for testing.

[danakj, 2016-03-25 18:18:09]

LGTM

https://codereview.chromium.org/1831883002/diff/60001/cc/output/software_rend...
File cc/output/software_renderer.cc (right):

https://codereview.chromium.org/1831883002/diff/60001/cc/output/software_rend...
cc/output/software_renderer.cc:690: return sk_sp<SkShader>();
can you just return nullptr? (sk_sp has a nullptr constructor i hope)

https://codereview.chromium.org/1831883002/diff/60001/cc/output/software_rend...
cc/output/software_renderer.cc:706: return sk_sp<SkShader>();
ditto

https://codereview.chromium.org/1831883002/diff/60001/ui/views/style/mac/dial...
File ui/views/style/mac/dialog_button_border_mac.cc (right):

https://codereview.chromium.org/1831883002/diff/60001/ui/views/style/mac/dial...
ui/views/style/mac/dialog_button_border_mac.cc:41: sk_sp<SkShader>
GetButtonGradient(int height,
mind s/Get/Create/ while you're here?

[f(malita), 2016-03-25 18:31:03]

lgtm

https://codereview.chromium.org/1831883002/diff/60001/cc/output/software_rend...
File cc/output/software_renderer.cc (right):

https://codereview.chromium.org/1831883002/diff/60001/cc/output/software_rend...
cc/output/software_renderer.cc:690: return sk_sp<SkShader>();
On 2016/03/25 18:18:08, danakj wrote:
> can you just return nullptr? (sk_sp has a nullptr constructor i hope)

+1

https://codereview.chromium.org/1831883002/diff/60001/skia/config/SkUserConfig.h
File skia/config/SkUserConfig.h (left):

https://codereview.chromium.org/1831883002/diff/60001/skia/config/SkUserConfi...
skia/config/SkUserConfig.h:267: #   define SK_SUPPORT_LEGACY_CREATESHADER_PTR
Did we convert Blink already?  I guess the bots will tell us.

[tomhudson, 2016-03-25 19:27:31]

https://codereview.chromium.org/1831883002/diff/60001/cc/output/software_rend...
File cc/output/software_renderer.cc (right):

https://codereview.chromium.org/1831883002/diff/60001/cc/output/software_rend...
cc/output/software_renderer.cc:690: return sk_sp<SkShader>();
On 2016/03/25 18:18:08, danakj wrote:
> can you just return nullptr? (sk_sp has a nullptr constructor i hope)

Done.

https://codereview.chromium.org/1831883002/diff/60001/cc/output/software_rend...
cc/output/software_renderer.cc:706: return sk_sp<SkShader>();
On 2016/03/25 18:18:08, danakj wrote:
> ditto

Done.

https://codereview.chromium.org/1831883002/diff/60001/skia/config/SkUserConfig.h
File skia/config/SkUserConfig.h (left):

https://codereview.chromium.org/1831883002/diff/60001/skia/config/SkUserConfi...
skia/config/SkUserConfig.h:267: #   define SK_SUPPORT_LEGACY_CREATESHADER_PTR
On 2016/03/25 18:31:03, f(malita) wrote:
> Did we convert Blink already?  I guess the bots will tell us.

Bots were happy with patchset #3; no Blink callers.
However, I'm *undoing* this deletion before landing this in Chrome because reed@
reused the flag in another CL that landed into Skia today. I'll do the followup
cleanup next week.

https://codereview.chromium.org/1831883002/diff/60001/ui/views/style/mac/dial...
File ui/views/style/mac/dialog_button_border_mac.cc (right):

https://codereview.chromium.org/1831883002/diff/60001/ui/views/style/mac/dial...
ui/views/style/mac/dialog_button_border_mac.cc:41: sk_sp<SkShader>
GetButtonGradient(int height,
On 2016/03/25 18:18:09, danakj wrote:
> mind s/Get/Create/ while you're here?

Done.

[tomhudson, 2016-03-25 19:27:35]

The CQ bit was checked by tomhudson@google.com

[tomhudson, 2016-03-25 19:27:36]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
fmalita@chromium.org
Link to the patchset: https://codereview.chromium.org/1831883002/#ps80001
(title: "Respond to reviews and REMOVE SkUserConfig CHANGE")

[commit-bot: I haz the power, 2016-03-25 19:27:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1831883002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1831883002/80001

[commit-bot: I haz the power, 2016-03-25 19:37:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-25 19:37:45]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tomhudson, 2016-03-25 19:49:47]

tomhudson@google.com changed reviewers:
+ estade@chromium.org, sky@chromium.org

[tomhudson, 2016-03-25 19:49:48]

estade@: please review chrome/browser/ui/libgtk2ui/, ui/native_theme/
sky@: please review chrome/browser/ui/views/, ui/views/

[sky, 2016-03-25 22:57:34]

LGTM

[tomhudson, 2016-03-30 13:56:02]

Description was changed from

==========
Use sk_sp-based shader creation APIs

Favor Skia's smart pointer based interface over raw pointers.
Switch Chrome (but not Blink) to sk_sp<SkShader> params
where feasible.

BUG=skia:5077,597620
R=fmalita@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Use sk_sp-based shader creation APIs

Favor Skia's smart pointer based interface over raw pointers.
Switch Chrome (but not Blink) to sk_sp<SkShader> params
where feasible.

BUG=skia:5077,597620
R=fmalita@chromium.org,danakj@chromium.org,sky@chromium.org
TBR=estade@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[tomhudson, 2016-03-31 12:33:55]

The CQ bit was checked by tomhudson@google.com

[tomhudson, 2016-03-31 12:33:56]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
fmalita@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1831883002/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2016-03-31 12:34:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1831883002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1831883002/100001

[commit-bot: I haz the power, 2016-03-31 14:10:23]

Description was changed from

==========
Use sk_sp-based shader creation APIs

Favor Skia's smart pointer based interface over raw pointers.
Switch Chrome (but not Blink) to sk_sp<SkShader> params
where feasible.

BUG=skia:5077,597620
R=fmalita@chromium.org,danakj@chromium.org,sky@chromium.org
TBR=estade@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Use sk_sp-based shader creation APIs

Favor Skia's smart pointer based interface over raw pointers.
Switch Chrome (but not Blink) to sk_sp<SkShader> params
where feasible.

BUG=skia:5077,597620
R=fmalita@chromium.org,danakj@chromium.org,sky@chromium.org
TBR=estade@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-03-31 14:10:24]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-03-31 14:11:46]

Description was changed from

==========
Use sk_sp-based shader creation APIs

Favor Skia's smart pointer based interface over raw pointers.
Switch Chrome (but not Blink) to sk_sp<SkShader> params
where feasible.

BUG=skia:5077,597620
R=fmalita@chromium.org,danakj@chromium.org,sky@chromium.org
TBR=estade@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Use sk_sp-based shader creation APIs

Favor Skia's smart pointer based interface over raw pointers.
Switch Chrome (but not Blink) to sk_sp<SkShader> params
where feasible.

BUG=skia:5077,597620
R=fmalita@chromium.org,danakj@chromium.org,sky@chromium.org
TBR=estade@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/2b45cf96adcc9d4902f926d9fd3ae17fb09d884e
Cr-Commit-Position: refs/heads/master@{#384266}
==========

[commit-bot: I haz the power, 2016-03-31 14:11:47]

Patchset 6 (id:??) landed as
https://crrev.com/2b45cf96adcc9d4902f926d9fd3ae17fb09d884e
Cr-Commit-Position: refs/heads/master@{#384266}