Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: ui/gfx/canvas.cc

Issue 1831883002: Use sk_sp-based shader creation APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « skia/ext/pixel_ref_utils_unittest.cc ('k') | ui/gfx/render_text.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/canvas.cc
diff --git a/ui/gfx/canvas.cc b/ui/gfx/canvas.cc
index 80b7df3810f6dc183ac2109b016f4761b2772a0f..895bf4f6c78adf307d93c72f7d1089bf7bafcfef 100644
--- a/ui/gfx/canvas.cc
+++ b/ui/gfx/canvas.cc
@@ -418,13 +418,10 @@ void Canvas::DrawImageInPath(const ImageSkia& image,
SkMatrix matrix;
matrix.setTranslate(SkIntToScalar(x), SkIntToScalar(y));
- skia::RefPtr<SkShader> shader = CreateImageRepShader(
- image_rep,
- SkShader::kRepeat_TileMode,
- matrix);
-
SkPaint p(paint);
- p.setShader(shader.get());
+ p.setShader(CreateImageRepShader(image_rep,
+ SkShader::kRepeat_TileMode,
+ matrix));
canvas_->drawPath(path, p);
}
@@ -558,15 +555,13 @@ void Canvas::DrawImageIntHelper(const ImageSkiaRep& image_rep,
shader_scale.preTranslate(SkIntToScalar(-src_x), SkIntToScalar(-src_y));
shader_scale.postTranslate(SkIntToScalar(dest_x), SkIntToScalar(dest_y));
- skia::RefPtr<SkShader> shader = CreateImageRepShaderForScale(
- image_rep, SkShader::kRepeat_TileMode, shader_scale,
- remove_image_scale ? image_rep.scale() : 1.f);
-
// Set up our paint to use the shader & release our reference (now just owned
// by the paint).
SkPaint p(paint);
p.setFilterQuality(filter ? kLow_SkFilterQuality : kNone_SkFilterQuality);
- p.setShader(shader.get());
+ p.setShader(CreateImageRepShaderForScale(
+ image_rep, SkShader::kRepeat_TileMode, shader_scale,
+ remove_image_scale ? image_rep.scale() : 1.f));
// The rect will be filled by the bitmap.
canvas_->drawRect(dest_rect, p);
« no previous file with comments | « skia/ext/pixel_ref_utils_unittest.cc ('k') | ui/gfx/render_text.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698