ui/views/style/mac/combobox_background_mac.cc - Issue 1831883002: Use sk_sp-based shader creation APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/style/mac/combobox_background_mac.cc

Issue 1831883002: Use sk_sp-based shader creation APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/style/mac/combobox_background_mac.cc

diff --git a/ui/views/style/mac/combobox_background_mac.cc b/ui/views/style/mac/combobox_background_mac.cc

index 8c7ef8f93a35b9cab68a3d3599c37c85f7d5af18..31997b15b781c824649b60f9cc7ae002ba5ee1e3 100644

--- a/ui/views/style/mac/combobox_background_mac.cc

+++ b/ui/views/style/mac/combobox_background_mac.cc

@@ -31,12 +31,11 @@ void ComboboxBackgroundMac::Paint(gfx::Canvas* canvas, View* view) const {

if (!combobox->enabled())

state = ui::NativeTheme::kDisabled;

- skia::RefPtr<SkShader> shader =

+ SkPaint paint;

+ paint.setShader(

ui::NativeThemeMac::GetButtonBackgroundShader(

state,

- bounds.height());

- SkPaint paint;

- paint.setShader(shader.get());

+ bounds.height()));

paint.setStyle(SkPaint::kFill_Style);

paint.setAntiAlias(true);