Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1829783002: [Extensions] Convert APIs to use movable types [5] (Closed)

Created:
4 years, 9 months ago by Devlin
Modified:
4 years, 9 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, tzik, nhiroki, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Convert APIs to use movable types [5] Generated extensions code used to rely on linked_ptrs for non-copyable types in containers. Now, we can make these types movable. Update the following APIs to use movable types in this CL: - file_browser_handler.json - file_browser_handler_internal.json - file_manager_private.idl - file_manager_private_internal.idl - file_system.idl - file_system_provider.idl - file_system_provider_internal.idl BUG=595949 Committed: https://crrev.com/467b5a8a1ccb999cbbd04a86bdec9a893e960a2c Cr-Commit-Position: refs/heads/master@{#383198}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -146 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/event_router.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_drive.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc View 1 chunk +9 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc View 6 chunks +28 lines, -31 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc View 1 chunk +10 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc View 5 chunks +17 lines, -23 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/get_actions.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/read_directory.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.cc View 3 chunks +10 lines, -14 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api_unittest.cc View 7 chunks +21 lines, -26 lines 0 comments Download
M chrome/common/extensions/api/file_browser_handler.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/file_browser_handler_internal.json View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/api/file_manager_private.idl View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/api/file_manager_private_internal.idl View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/api/file_system.idl View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/file_system_provider.idl View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/api/file_system_provider_internal.idl View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
Devlin
4 years, 9 months ago (2016-03-23 18:00:09 UTC) #3
asargent_no_longer_on_chrome
lgtm
4 years, 9 months ago (2016-03-23 22:37:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829783002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829783002/20001
4 years, 9 months ago (2016-03-24 21:21:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/160597)
4 years, 9 months ago (2016-03-24 21:40:13 UTC) #8
Devlin
+Steven for c/b/chromeos/file_system_provider*
4 years, 9 months ago (2016-03-24 21:46:05 UTC) #10
stevenjb
lgtm
4 years, 9 months ago (2016-03-24 21:56:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829783002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829783002/20001
4 years, 9 months ago (2016-03-25 00:04:37 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 9 months ago (2016-03-25 00:10:56 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 00:12:22 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/467b5a8a1ccb999cbbd04a86bdec9a893e960a2c
Cr-Commit-Position: refs/heads/master@{#383198}

Powered by Google App Engine
This is Rietveld 408576698