Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4153)

Unified Diff: chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc

Issue 1829783002: [Extensions] Convert APIs to use movable types [5] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc b/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
index 25873226354d343d54f49704d65389a2774841a8..d47825f2e856c7310c9ce5784fe1cfbf036bfe8a 100644
--- a/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
@@ -804,18 +804,17 @@ void FileManagerPrivateInternalResolveIsolatedEntriesFunction::
RunAsyncAfterConvertFileDefinitionListToEntryDefinitionList(scoped_ptr<
file_manager::util::EntryDefinitionList> entry_definition_list) {
using extensions::api::file_manager_private_internal::EntryDescription;
- std::vector<linked_ptr<EntryDescription> > entries;
+ std::vector<EntryDescription> entries;
- for (size_t i = 0; i < entry_definition_list->size(); ++i) {
- if (entry_definition_list->at(i).error != base::File::FILE_OK)
+ for (const auto& definition : *entry_definition_list) {
+ if (definition.error != base::File::FILE_OK)
continue;
- linked_ptr<EntryDescription> entry(new EntryDescription);
- entry->file_system_name = entry_definition_list->at(i).file_system_name;
- entry->file_system_root = entry_definition_list->at(i).file_system_root_url;
- entry->file_full_path =
- "/" + entry_definition_list->at(i).full_path.AsUTF8Unsafe();
- entry->file_is_directory = entry_definition_list->at(i).is_directory;
- entries.push_back(entry);
+ EntryDescription entry;
+ entry.file_system_name = definition.file_system_name;
+ entry.file_system_root = definition.file_system_root_url;
+ entry.file_full_path = "/" + definition.full_path.AsUTF8Unsafe();
+ entry.file_is_directory = definition.is_directory;
+ entries.push_back(std::move(entry));
}
results_ = extensions::api::file_manager_private_internal::

Powered by Google App Engine
This is Rietveld 408576698