Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4680)

Unified Diff: chrome/browser/chromeos/extensions/file_manager/event_router.cc

Issue 1829783002: [Extensions] Convert APIs to use movable types [5] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/extensions/file_manager/private_api_drive.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/extensions/file_manager/event_router.cc
diff --git a/chrome/browser/chromeos/extensions/file_manager/event_router.cc b/chrome/browser/chromeos/extensions/file_manager/event_router.cc
index 6fa399bfa8868727aa72eec59b097072011f656c..91fc87a03f299540244cccde3c9f8a86e15cde33 100644
--- a/chrome/browser/chromeos/extensions/file_manager/event_router.cc
+++ b/chrome/browser/chromeos/extensions/file_manager/event_router.cc
@@ -852,7 +852,7 @@ void EventRouter::DispatchDirectoryChangeEventWithEntryDefinition(
// Detailed information is available.
if (list.get()) {
event.changed_files.reset(
- new std::vector<linked_ptr<file_manager_private::FileChange> >);
+ new std::vector<file_manager_private::FileChange>());
if (list->map().empty())
return;
@@ -860,22 +860,21 @@ void EventRouter::DispatchDirectoryChangeEventWithEntryDefinition(
for (drive::FileChange::Map::const_iterator it = list->map().begin();
it != list->map().end();
it++) {
- linked_ptr<file_manager_private::FileChange> change_list(
- new file_manager_private::FileChange);
+ file_manager_private::FileChange change_list;
GURL url = util::ConvertDrivePathToFileSystemUrl(
profile_, it->first, *extension_id);
- change_list->url = url.spec();
+ change_list.url = url.spec();
for (drive::FileChange::ChangeList::List::const_iterator change =
it->second.list().begin();
change != it->second.list().end();
change++) {
- change_list->changes.push_back(
+ change_list.changes.push_back(
ConvertChangeTypeFromDriveToApi(change->change()));
}
- event.changed_files->push_back(change_list);
+ event.changed_files->push_back(std::move(change_list));
}
}
« no previous file with comments | « no previous file | chrome/browser/chromeos/extensions/file_manager/private_api_drive.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698