Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: chrome/browser/chromeos/file_system_provider/operations/read_directory.cc

Issue 1829783002: [Extensions] Convert APIs to use movable types [5] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/file_system_provider/operations/read_directory.cc
diff --git a/chrome/browser/chromeos/file_system_provider/operations/read_directory.cc b/chrome/browser/chromeos/file_system_provider/operations/read_directory.cc
index bfce1e4191a460952e2eb6d55a51065828c69a81..3cad4e2d759c3d7abf8eb9bfb7273ce94032ef90 100644
--- a/chrome/browser/chromeos/file_system_provider/operations/read_directory.cc
+++ b/chrome/browser/chromeos/file_system_provider/operations/read_directory.cc
@@ -9,7 +9,6 @@
#include <string>
#include <utility>
-#include "base/memory/linked_ptr.h"
#include "chrome/browser/chromeos/file_system_provider/operations/get_metadata.h"
#include "chrome/common/extensions/api/file_system_provider.h"
#include "chrome/common/extensions/api/file_system_provider_internal.h"
@@ -30,10 +29,9 @@ bool ConvertRequestValueToEntryList(scoped_ptr<RequestValue> value,
if (!params)
return false;
- for (size_t i = 0; i < params->entries.size(); ++i) {
- const linked_ptr<EntryMetadata> entry_metadata = params->entries[i];
+ for (const EntryMetadata& entry_metadata : params->entries) {
if (!ValidateIDLEntryMetadata(
- *entry_metadata,
+ entry_metadata,
ProvidedFileSystemInterface::METADATA_FIELD_IS_DIRECTORY |
ProvidedFileSystemInterface::METADATA_FIELD_NAME,
false /* root_entry */)) {
@@ -41,8 +39,8 @@ bool ConvertRequestValueToEntryList(scoped_ptr<RequestValue> value,
}
storage::DirectoryEntry output_entry;
- output_entry.is_directory = *entry_metadata->is_directory;
- output_entry.name = *entry_metadata->name;
+ output_entry.is_directory = *entry_metadata.is_directory;
+ output_entry.name = *entry_metadata.name;
output->push_back(output_entry);
}

Powered by Google App Engine
This is Rietveld 408576698