chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc - Issue 1829783002: [Extensions] Convert APIs to use movable types [5]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc

Issue 1829783002: [Extensions] Convert APIs to use movable types [5] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/file_manager/private_api_drive.h ('k') | chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc

diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc b/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc

index feacc46928fcad0cbf3955cca09ab26303d31dba..7fd40477b798d770b8f224efdec0e61067ba7fc6 100644

--- a/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc

+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc

@@ -586,11 +586,11 @@ void FileManagerPrivateInternalGetEntryPropertiesFunction::

DCHECK_CURRENTLY_ON(BrowserThread::UI);

DCHECK(0 <= processed_count_ && processed_count_ < properties_list_.size());

- properties_list_[index] = make_linked_ptr(properties.release());

if (error == base::File::FILE_OK) {

- properties_list_[index]->external_file_url.reset(

+ properties->external_file_url.reset(

new std::string(chromeos::FileSystemURLToExternalFileURL(url).spec()));

}

+ properties_list_[index] = std::move(*properties);

processed_count_++;

if (processed_count_ < properties_list_.size())