Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1603)

Unified Diff: chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc

Issue 1829783002: [Extensions] Convert APIs to use movable types [5] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc
diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc b/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc
index 0d39a2af1ec3830a053ac941059544a12c336bda..cde13812e0d2a601ce349220191f9ef4d88f0ff9 100644
--- a/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc
+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc
@@ -190,18 +190,17 @@ void FileManagerPrivateInternalGetFileTasksFunction::
// Convert the tasks into JSON compatible objects.
using api::file_manager_private::FileTask;
- std::vector<linked_ptr<FileTask> > results;
- for (size_t i = 0; i < tasks.size(); ++i) {
- const file_manager::file_tasks::FullTaskDescriptor& task = tasks[i];
- const linked_ptr<FileTask> converted(new FileTask);
- converted->task_id = file_manager::file_tasks::TaskDescriptorToId(
- task.task_descriptor());
+ std::vector<FileTask> results;
+ for (const file_manager::file_tasks::FullTaskDescriptor& task : tasks) {
+ FileTask converted;
+ converted.task_id =
+ file_manager::file_tasks::TaskDescriptorToId(task.task_descriptor());
if (!task.icon_url().is_empty())
- converted->icon_url = task.icon_url().spec();
- converted->title = task.task_title();
- converted->is_default = task.is_default();
- converted->is_generic_file_handler = task.is_generic_file_handler();
- results.push_back(converted);
+ converted.icon_url = task.icon_url().spec();
+ converted.title = task.task_title();
+ converted.is_default = task.is_default();
+ converted.is_generic_file_handler = task.is_generic_file_handler();
+ results.push_back(std::move(converted));
}
results_ = extensions::api::file_manager_private_internal::GetFileTasks::

Powered by Google App Engine
This is Rietveld 408576698