Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4108)

Unified Diff: chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc

Issue 1829783002: [Extensions] Convert APIs to use movable types [5] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc
diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc b/chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc
index 201918b22168db0647d8832186a2d20c97b5d239..7df6870546727aca362c42964a9b06221fba83ea 100644
--- a/chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc
+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc
@@ -227,13 +227,12 @@ bool FileManagerPrivateGetVolumeMetadataListFunction::RunAsync() {
file_manager::VolumeManager::Get(GetProfile())->GetVolumeList();
std::string log_string;
- std::vector<linked_ptr<file_manager_private::VolumeMetadata> > result;
+ std::vector<file_manager_private::VolumeMetadata> result;
for (const auto& volume : volume_list) {
- linked_ptr<file_manager_private::VolumeMetadata> volume_metadata(
- new file_manager_private::VolumeMetadata);
- file_manager::util::VolumeToVolumeMetadata(GetProfile(), *volume.get(),
- volume_metadata.get());
- result.push_back(volume_metadata);
+ file_manager_private::VolumeMetadata volume_metadata;
+ file_manager::util::VolumeToVolumeMetadata(GetProfile(), *volume,
+ &volume_metadata);
+ result.push_back(std::move(volume_metadata));
if (!log_string.empty())
log_string += ", ";
log_string += volume->mount_path().AsUTF8Unsafe();

Powered by Google App Engine
This is Rietveld 408576698