Use sk_sp-based picture recording APIs

Use sk_sp-based picture recording APIs

1) use SkPictureRecorder::finishRecordingAsPicture() over
   endRecordingAsPicture()

2) convert to sk_sp<SkPicture> fields/params where feasible

BUG=skia:5077
R=reed@google.com,danakj@chromium.org,enne@chromium.org
TBR=pdr@chromium.org,alekseys@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/2d743288889c7804e6431bf389cdc6084aaa49ef
Cr-Commit-Position: refs/heads/master@{#382563}

[f(malita), 2016-03-20 01:02:47]

Description was changed from

==========
Use sk_sp-based picture recording APIs



BUG=
==========

to

==========
Use sk_sp-based picture recording APIs



BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[f(malita), 2016-03-20 03:03:11]

Description was changed from

==========
Use sk_sp-based picture recording APIs



BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Use sk_sp-based picture recording APIs

1) use SkPictureRecorder::finishRecordingAsPicture() over
   endRecordingAsPicture()

2) convert to sk_sp<SkPicture>-base fields/methods where feasible


BUG=skia:5077
R=reed@google.com,danakj@chromium.org,enne@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[f(malita), 2016-03-20 03:03:34]

Description was changed from

==========
Use sk_sp-based picture recording APIs

1) use SkPictureRecorder::finishRecordingAsPicture() over
   endRecordingAsPicture()

2) convert to sk_sp<SkPicture>-base fields/methods where feasible


BUG=skia:5077
R=reed@google.com,danakj@chromium.org,enne@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Use sk_sp-based picture recording APIs

1) use SkPictureRecorder::finishRecordingAsPicture() over
   endRecordingAsPicture()

2) convert to sk_sp<SkPicture> fields/methods where feasible


BUG=skia:5077
R=reed@google.com,danakj@chromium.org,enne@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[f(malita), 2016-03-20 03:05:52]

Description was changed from

==========
Use sk_sp-based picture recording APIs

1) use SkPictureRecorder::finishRecordingAsPicture() over
   endRecordingAsPicture()

2) convert to sk_sp<SkPicture> fields/methods where feasible


BUG=skia:5077
R=reed@google.com,danakj@chromium.org,enne@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Use sk_sp-based picture recording APIs

1) use SkPictureRecorder::finishRecordingAsPicture() over
   endRecordingAsPicture()

2) convert to sk_sp<SkPicture> fields/params where feasible


BUG=skia:5077
R=reed@google.com,danakj@chromium.org,enne@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[f(malita), 2016-03-20 03:10:04]

fmalita@chromium.org changed reviewers:
+ danakj@chromium.org, enne@chromium.org, reed@google.com

[f(malita), 2016-03-20 03:12:03]

This is the Chromium side, there's also a Blink CL to follow (the Blink diffs
here are only to support the interface changes).

[reed1, 2016-03-21 13:07:56]

https://codereview.chromium.org/1819683002/diff/100001/cc/blink/web_display_i...
File cc/blink/web_display_item_list_impl.h (right):

https://codereview.chromium.org/1819683002/diff/100001/cc/blink/web_display_i...
cc/blink/web_display_item_list_impl.h:46: sk_sp<const SkPicture>) override;
At some point it will be awkward to still have some 'const picture' when skia is
definitely moving to just 'picture'.

https://codereview.chromium.org/1819683002/diff/100001/cc/playback/display_li...
File cc/playback/display_list_raster_source.cc (right):

https://codereview.chromium.org/1819683002/diff/100001/cc/playback/display_li...
cc/playback/display_list_raster_source.cc:263: skia::RefPtr<SkPicture>
DisplayListRasterSource::GetFlattenedPicture() {
Is it too long a thread to change this return type to sk_sp?

[f(malita), 2016-03-21 14:27:50]

https://codereview.chromium.org/1819683002/diff/100001/cc/blink/web_display_i...
File cc/blink/web_display_item_list_impl.h (right):

https://codereview.chromium.org/1819683002/diff/100001/cc/blink/web_display_i...
cc/blink/web_display_item_list_impl.h:46: sk_sp<const SkPicture>) override;
On 2016/03/21 13:07:55, reed1 wrote:
> At some point it will be awkward to still have some 'const picture' when skia
is
> definitely moving to just 'picture'.

Yup, there's a de-constification CL on my todo list.  That'll be part of
switching to the sk_sp drawing API (which takes non-const picture sksps).

https://codereview.chromium.org/1819683002/diff/100001/cc/playback/display_li...
File cc/playback/display_list_raster_source.cc (right):

https://codereview.chromium.org/1819683002/diff/100001/cc/playback/display_li...
cc/playback/display_list_raster_source.cc:263: skia::RefPtr<SkPicture>
DisplayListRasterSource::GetFlattenedPicture() {
On 2016/03/21 13:07:56, reed1 wrote:
> Is it too long a thread to change this return type to sk_sp?

Not nearly as long as I expected for an interface change.

Done.

[enne (OOO), 2016-03-21 17:57:26]

lgtm

[f(malita), 2016-03-21 18:24:52]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2016-03-21 18:25:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1819683002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1819683002/120001

[f(malita), 2016-03-21 18:25:31]

The CQ bit was unchecked by fmalita@chromium.org

[f(malita), 2016-03-21 18:59:13]

fmalita@chromium.org changed reviewers:
+ alekseys@chromium.org, pdr@chromium.org

[f(malita), 2016-03-21 19:00:32]

+ moar owners

printing/ -> alekseys
third_party/WebKit/Source/web -> pdr
ui/compositor -> danakj

[danakj, 2016-03-21 20:59:39]

ui/compositor LGTM

[f(malita), 2016-03-22 13:26:05]

Description was changed from

==========
Use sk_sp-based picture recording APIs

1) use SkPictureRecorder::finishRecordingAsPicture() over
   endRecordingAsPicture()

2) convert to sk_sp<SkPicture> fields/params where feasible


BUG=skia:5077
R=reed@google.com,danakj@chromium.org,enne@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Use sk_sp-based picture recording APIs

1) use SkPictureRecorder::finishRecordingAsPicture() over
   endRecordingAsPicture()

2) convert to sk_sp<SkPicture> fields/params where feasible


BUG=skia:5077
R=reed@google.com,danakj@chromium.org,enne@chromium.org
TBR=pdr@chromium.org,alekseys@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[f(malita), 2016-03-22 13:26:17]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2016-03-22 13:26:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1819683002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1819683002/120001

[commit-bot: I haz the power, 2016-03-22 13:32:24]

Description was changed from

==========
Use sk_sp-based picture recording APIs

1) use SkPictureRecorder::finishRecordingAsPicture() over
   endRecordingAsPicture()

2) convert to sk_sp<SkPicture> fields/params where feasible


BUG=skia:5077
R=reed@google.com,danakj@chromium.org,enne@chromium.org
TBR=pdr@chromium.org,alekseys@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Use sk_sp-based picture recording APIs

1) use SkPictureRecorder::finishRecordingAsPicture() over
   endRecordingAsPicture()

2) convert to sk_sp<SkPicture> fields/params where feasible


BUG=skia:5077
R=reed@google.com,danakj@chromium.org,enne@chromium.org
TBR=pdr@chromium.org,alekseys@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-03-22 13:32:26]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-03-22 13:33:24]

Description was changed from

==========
Use sk_sp-based picture recording APIs

1) use SkPictureRecorder::finishRecordingAsPicture() over
   endRecordingAsPicture()

2) convert to sk_sp<SkPicture> fields/params where feasible


BUG=skia:5077
R=reed@google.com,danakj@chromium.org,enne@chromium.org
TBR=pdr@chromium.org,alekseys@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Use sk_sp-based picture recording APIs

1) use SkPictureRecorder::finishRecordingAsPicture() over
   endRecordingAsPicture()

2) convert to sk_sp<SkPicture> fields/params where feasible

BUG=skia:5077
R=reed@google.com,danakj@chromium.org,enne@chromium.org
TBR=pdr@chromium.org,alekseys@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/2d743288889c7804e6431bf389cdc6084aaa49ef
Cr-Commit-Position: refs/heads/master@{#382563}
==========

[commit-bot: I haz the power, 2016-03-22 13:33:26]

Patchset 7 (id:??) landed as
https://crrev.com/2d743288889c7804e6431bf389cdc6084aaa49ef
Cr-Commit-Position: refs/heads/master@{#382563}