cc/trees/layer_tree_host_pixeltest_masks.cc - Issue 1819683002: Use sk_sp-based picture recording APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/layer_tree_host_pixeltest_masks.cc

Issue 1819683002: Use sk_sp-based picture recording APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: skspify GetPicture/GetFlattenedPicture Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/trees/layer_tree_host_pixeltest_masks.cc

diff --git a/cc/trees/layer_tree_host_pixeltest_masks.cc b/cc/trees/layer_tree_host_pixeltest_masks.cc

index 890e94ad6b44a32bdb3b2ff11431406999ea03f9..3a6f1278e0aaa01ca007aef69c40c12ae06ad1a0 100644

--- a/cc/trees/layer_tree_host_pixeltest_masks.cc

+++ b/cc/trees/layer_tree_host_pixeltest_masks.cc

@@ -61,7 +61,7 @@ class MaskContentLayerClient : public ContentLayerClient {

scoped_refptr<DisplayItemList> display_list =

DisplayItemList::Create(PaintableRegion(), DisplayItemListSettings());

display_list->CreateAndAppendItem<DrawingDisplayItem>(

- PaintableRegion(), skia::AdoptRef(recorder.endRecordingAsPicture()));

+ PaintableRegion(), recorder.finishRecordingAsPicture());

display_list->Finalize();

return display_list;

@@ -329,7 +329,7 @@ class CheckerContentLayerClient : public ContentLayerClient {

scoped_refptr<DisplayItemList> display_list =

DisplayItemList::Create(PaintableRegion(), DisplayItemListSettings());

display_list->CreateAndAppendItem<DrawingDisplayItem>(

- PaintableRegion(), skia::AdoptRef(recorder.endRecordingAsPicture()));

+ PaintableRegion(), recorder.finishRecordingAsPicture());

display_list->Finalize();

return display_list;

@@ -367,7 +367,7 @@ class CircleContentLayerClient : public ContentLayerClient {

scoped_refptr<DisplayItemList> display_list =

DisplayItemList::Create(PaintableRegion(), DisplayItemListSettings());

display_list->CreateAndAppendItem<DrawingDisplayItem>(

- PaintableRegion(), skia::AdoptRef(recorder.endRecordingAsPicture()));

+ PaintableRegion(), recorder.finishRecordingAsPicture());

display_list->Finalize();

return display_list;