third_party/WebKit/Source/web/LinkHighlightImpl.cpp - Issue 1819683002: Use sk_sp-based picture recording APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/LinkHighlightImpl.cpp

Issue 1819683002: Use sk_sp-based picture recording APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: skspify GetPicture/GetFlattenedPicture Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/LinkHighlightImpl.cpp

diff --git a/third_party/WebKit/Source/web/LinkHighlightImpl.cpp b/third_party/WebKit/Source/web/LinkHighlightImpl.cpp

index edb360a04620832ca575b958185f82aef4d3d0af..7d8e6e6a6cef7b1e44136e8ae5d075eda789ab9d 100644

--- a/third_party/WebKit/Source/web/LinkHighlightImpl.cpp

+++ b/third_party/WebKit/Source/web/LinkHighlightImpl.cpp

@@ -273,8 +273,8 @@ void LinkHighlightImpl::paintContents(WebDisplayItemList* webDisplayItemList, We

paint.setColor(m_node->layoutObject()->style()->tapHighlightColor().rgb());

canvas->drawPath(m_path.getSkPath(), paint);

- RefPtr<const SkPicture> picture = adoptRef(recorder.endRecording());

- webDisplayItemList->appendDrawingItem(WebRect(visualRect.x(), visualRect.y(), visualRect.width(), visualRect.height()), picture.get());

+ webDisplayItemList->appendDrawingItem(WebRect(visualRect.x(), visualRect.y(),

+ visualRect.width(), visualRect.height()), recorder.finishRecordingAsPicture());

}

void LinkHighlightImpl::startHighlightAnimationIfNeeded()