third_party/WebKit/public/platform/WebDisplayItemList.h - Issue 1819683002: Use sk_sp-based picture recording APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/WebDisplayItemList.h

Issue 1819683002: Use sk_sp-based picture recording APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: skspify GetPicture/GetFlattenedPicture Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/public/platform/WebDisplayItemList.h

diff --git a/third_party/WebKit/public/platform/WebDisplayItemList.h b/third_party/WebKit/public/platform/WebDisplayItemList.h

index e9dd954b5abf0c230a30b510ad37a31f6d810be7..b71d422a79aa548cc2b636c7369eeb277e48e9ef 100644

--- a/third_party/WebKit/public/platform/WebDisplayItemList.h

+++ b/third_party/WebKit/public/platform/WebDisplayItemList.h

@@ -14,6 +14,7 @@

#include "third_party/skia/include/core/SkColorFilter.h"

#include "third_party/skia/include/core/SkRRect.h"

+#include "third_party/skia/include/core/SkRefCnt.h"

#include "third_party/skia/include/core/SkRegion.h"

#include "third_party/skia/include/core/SkXfermode.h"

#include "third_party/skia/include/utils/SkMatrix44.h"

@@ -36,8 +37,7 @@ class WebDisplayItemList {

public:

virtual ~WebDisplayItemList() { }

- // This grabs a ref on the passed-in SkPicture.

- virtual void appendDrawingItem(const WebRect& visualRect, const SkPicture*) { }

+ virtual void appendDrawingItem(const WebRect& visualRect, sk_sp<const SkPicture>) { }

virtual void appendClipItem(const WebRect& visualRect, const WebRect& clipRect, const WebVector<SkRRect>& roundedClipRects) { }

virtual void appendEndClipItem(const WebRect& visualRect) { }