skia/ext/analysis_canvas_unittest.cc - Issue 1819683002: Use sk_sp-based picture recording APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: skia/ext/analysis_canvas_unittest.cc

Issue 1819683002: Use sk_sp-based picture recording APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: skspify GetPicture/GetFlattenedPicture Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: skia/ext/analysis_canvas_unittest.cc

diff --git a/skia/ext/analysis_canvas_unittest.cc b/skia/ext/analysis_canvas_unittest.cc

index 5436b8130c96733c92d91545ac9a13f9d691473f..bac22b11eac0a152921e0af74b31377062cae8c1 100644

--- a/skia/ext/analysis_canvas_unittest.cc

+++ b/skia/ext/analysis_canvas_unittest.cc

@@ -345,8 +345,7 @@ TEST(AnalysisCanvasTest, EarlyOutNotSolid) {

record_canvas->drawText(

text.c_str(), text.length(), point.fX, point.fY, paint);

- skia::RefPtr<SkPicture> picture =

- skia::AdoptRef(recorder.endRecordingAsPicture());

+ sk_sp<SkPicture> picture = recorder.finishRecordingAsPicture();

// Draw the picture into the analysis canvas, using the canvas as a callback

// as well.

« no previous file with comments | « printing/pdf_metafile_skia.cc ('k') | skia/ext/pixel_ref_utils_unittest.cc » ('j') | no next file with comments »