third_party/WebKit/Source/platform/graphics/paint/PaintArtifactToSkCanvas.cpp - Issue 1819683002: Use sk_sp-based picture recording APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/PaintArtifactToSkCanvas.cpp

Issue 1819683002: Use sk_sp-based picture recording APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: skspify GetPicture/GetFlattenedPicture Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/paint/PaintArtifactToSkCanvas.h ('k') | third_party/WebKit/Source/web/LinkHighlightImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/paint/PaintArtifactToSkCanvas.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/paint/PaintArtifactToSkCanvas.cpp b/third_party/WebKit/Source/platform/graphics/paint/PaintArtifactToSkCanvas.cpp

index e95d8327348c30f8a963a9b6f5e22b13aa2bbce7..1bd718d792a568c58cbda61f94a48cb6d660e68d 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/PaintArtifactToSkCanvas.cpp

+++ b/third_party/WebKit/Source/platform/graphics/paint/PaintArtifactToSkCanvas.cpp

@@ -136,12 +136,12 @@ void paintArtifactToSkCanvas(const PaintArtifact& artifact, SkCanvas* canvas)

}

-PassRefPtr<SkPicture> paintArtifactToSkPicture(const PaintArtifact& artifact, const SkRect& bounds)

+sk_sp<const SkPicture> paintArtifactToSkPicture(const PaintArtifact& artifact, const SkRect& bounds)

{

SkPictureRecorder recorder;

SkCanvas* canvas = recorder.beginRecording(bounds);

paintArtifactToSkCanvas(artifact, canvas);

- return adoptRef(recorder.endRecordingAsPicture());

+ return recorder.finishRecordingAsPicture();

}

} // namespace blink