third_party/WebKit/Source/platform/graphics/ContentLayerDelegate.cpp - Issue 1819683002: Use sk_sp-based picture recording APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/ContentLayerDelegate.cpp

Issue 1819683002: Use sk_sp-based picture recording APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: skspify GetPicture/GetFlattenedPicture Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « skia/ext/pixel_ref_utils_unittest.cc ('k') | third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/ContentLayerDelegate.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/ContentLayerDelegate.cpp b/third_party/WebKit/Source/platform/graphics/ContentLayerDelegate.cpp

index da8a4ae19bcff1c00e71db6409ae4c80bb12a62b..5c21c9cb9907fa19735ba90f657fcb3cdc993eaa 100644

--- a/third_party/WebKit/Source/platform/graphics/ContentLayerDelegate.cpp

+++ b/third_party/WebKit/Source/platform/graphics/ContentLayerDelegate.cpp

@@ -57,8 +57,8 @@ static void paintArtifactToWebDisplayItemList(WebDisplayItemList* list, const Pa

// separate layers and send those to the compositor, instead of sending

// one big flat SkPicture.

SkRect skBounds = SkRect::MakeXYWH(bounds.x(), bounds.y(), bounds.width(), bounds.height());

- RefPtr<SkPicture> picture = paintArtifactToSkPicture(artifact, skBounds);

- list->appendDrawingItem(WebRect(bounds.x(), bounds.y(), bounds.width(), bounds.height()), picture.get());

+ list->appendDrawingItem(WebRect(bounds.x(), bounds.y(), bounds.width(), bounds.height()),

+ paintArtifactToSkPicture(artifact, skBounds));

return;

}

artifact.appendToWebDisplayItemList(list);