|
Scaling and offset fix for FELighting (software and skia paths)
This fixes scaling (including z-scaling) caused by page zoom and high dpi settings (pinch zoom still todo).
This also fixes the light position, since the light origin was misplaced when a non 0 filter effect region x and y parameters were used (which is the case by default). The origin was affected by these values, which shouldn't be the case, as these provide extra space to render an effect, like a blur, for example, but should not changed the effect's coordinate system.
BUG=
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168526
Total comments: 6
Total comments: 2
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+167 lines, -125 lines) |
Patch |
|
M |
LayoutTests/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.txt
|
View
|
1
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
LayoutTests/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.txt
|
View
|
1
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
LayoutTests/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.txt
|
View
|
1
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
LayoutTests/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.txt
|
View
|
1
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
LayoutTests/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.txt
|
View
|
1
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
LayoutTests/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.txt
|
View
|
1
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
LayoutTests/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.txt
|
View
|
1
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
LayoutTests/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.txt
|
View
|
1
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
LayoutTests/svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-limitingConeAngle-attr.js
|
View
|
1
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
LayoutTests/svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-pointsAtX-attr.js
|
View
|
1
|
2 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
|
M |
LayoutTests/svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-pointsAtY-attr.js
|
View
|
1
|
2 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
|
M |
LayoutTests/svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-pointsAtZ-attr.js
|
View
|
1
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
LayoutTests/svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-specularExponent-attr.js
|
View
|
1
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
LayoutTests/svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-x-attr.js
|
View
|
1
|
2 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
|
M |
LayoutTests/svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-y-attr.js
|
View
|
1
|
2 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
|
M |
LayoutTests/svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-z-attr.js
|
View
|
1
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
LayoutTests/svg/dynamic-updates/script-tests/SVGFESpotLightElement-svgdom-limitingConeAngle-prop.js
|
View
|
1
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
LayoutTests/svg/dynamic-updates/script-tests/SVGFESpotLightElement-svgdom-pointsAtX-prop.js
|
View
|
1
|
2 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
|
M |
LayoutTests/svg/dynamic-updates/script-tests/SVGFESpotLightElement-svgdom-pointsAtY-prop.js
|
View
|
1
|
2 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
|
M |
LayoutTests/svg/dynamic-updates/script-tests/SVGFESpotLightElement-svgdom-pointsAtZ-prop.js
|
View
|
1
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
LayoutTests/svg/dynamic-updates/script-tests/SVGFESpotLightElement-svgdom-specularExponent-prop.js
|
View
|
1
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
LayoutTests/svg/dynamic-updates/script-tests/SVGFESpotLightElement-svgdom-x-prop.js
|
View
|
1
|
2 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
|
M |
LayoutTests/svg/dynamic-updates/script-tests/SVGFESpotLightElement-svgdom-y-prop.js
|
View
|
1
|
2 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
|
M |
LayoutTests/svg/dynamic-updates/script-tests/SVGFESpotLightElement-svgdom-z-prop.js
|
View
|
1
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
Source/platform/graphics/cpu/arm/filters/FELightingNEON.h
|
View
|
1
2
|
2 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
Source/platform/graphics/filters/DistantLightSource.h
|
View
|
1
2
|
1 chunk |
+7 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/platform/graphics/filters/DistantLightSource.cpp
|
View
|
1
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/platform/graphics/filters/FELighting.h
|
View
|
1
2
|
2 chunks |
+3 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/platform/graphics/filters/FELighting.cpp
|
View
|
1
2
|
3 chunks |
+21 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/platform/graphics/filters/LightSource.h
|
View
|
1
2
|
1 chunk |
+4 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/platform/graphics/filters/PointLightSource.h
|
View
|
1
2
|
1 chunk |
+8 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/platform/graphics/filters/PointLightSource.cpp
|
View
|
1
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/platform/graphics/filters/SpotLightSource.h
|
View
|
1
2
|
2 chunks |
+9 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/platform/graphics/filters/SpotLightSource.cpp
|
View
|
1
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
Total messages: 10 (0 generated)
|