Source/platform/graphics/filters/DistantLightSource.h - Issue 181943003: Scaling and offset fix for FELighting (software and skia paths)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/filters/DistantLightSource.h

Issue 181943003: Scaling and offset fix for FELighting (software and skia paths) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Changed fix to temporary light creation Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/platform/graphics/cpu/arm/filters/FELightingNEON.h ('k') | Source/platform/graphics/filters/DistantLightSource.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/graphics/filters/DistantLightSource.h

diff --git a/Source/platform/graphics/filters/DistantLightSource.h b/Source/platform/graphics/filters/DistantLightSource.h

index 969fa5b5048bd84eb8252f3eddf77498232ffd68..65814e0504e740c61248a6d8f68bd7ab201338dd 100644

--- a/Source/platform/graphics/filters/DistantLightSource.h

+++ b/Source/platform/graphics/filters/DistantLightSource.h

@@ -34,14 +34,19 @@ public:

return adoptRef(new DistantLightSource(azimuth, elevation));

}

+ virtual PassRefPtr<LightSource> create(const FloatPoint3D& scale, const FloatSize& offset) const OVERRIDE

+ {

+ return adoptRef(new DistantLightSource(m_azimuth, m_elevation));

+ }

float azimuth() const { return m_azimuth; }

float elevation() const { return m_elevation; }

virtual bool setAzimuth(float) OVERRIDE;

virtual bool setElevation(float) OVERRIDE;

- virtual void initPaintingData(PaintingData&) OVERRIDE;

- virtual void updatePaintingData(PaintingData&, int x, int y, float z) OVERRIDE;

+ virtual void initPaintingData(PaintingData&) const OVERRIDE;

+ virtual void updatePaintingData(PaintingData&, int x, int y, float z) const OVERRIDE;

virtual TextStream& externalRepresentation(TextStream&) const OVERRIDE;