Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: LayoutTests/svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-y-attr.js

Issue 181943003: Scaling and offset fix for FELighting (software and skia paths) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Changed fix to temporary light creation Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-y-attr.js
diff --git a/LayoutTests/svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-y-attr.js b/LayoutTests/svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-y-attr.js
index e78cddef8b98b717948ccf5df01c77dba80d72a1..c1257d37676de9522cf2e85b0f3f81a2690c6a5f 100644
--- a/LayoutTests/svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-y-attr.js
+++ b/LayoutTests/svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-y-attr.js
@@ -5,11 +5,11 @@ description("Tests dynamic updates of the 'y' attribute of the SVGFESpotLightEle
createSVGTestCase();
var spotLightElement = createSVGElement("feSpotLight");
-spotLightElement.setAttribute("x", "113");
-spotLightElement.setAttribute("y", "100");
+spotLightElement.setAttribute("x", "83");
+spotLightElement.setAttribute("y", "70");
spotLightElement.setAttribute("z", "100");
-spotLightElement.setAttribute("pointsAtX", "113");
-spotLightElement.setAttribute("pointsAtY", "100");
+spotLightElement.setAttribute("pointsAtX", "83");
+spotLightElement.setAttribute("pointsAtY", "70");
spotLightElement.setAttribute("pointsAtZ", "0");
spotLightElement.setAttribute("specularExponent", "1");
spotLightElement.setAttribute("limitingConeAngle", "15");
@@ -38,11 +38,11 @@ rectElement.setAttribute("height", "200");
rectElement.setAttribute("filter", "url(#myFilter)");
rootSVGElement.appendChild(rectElement);
-shouldBeEqualToString("spotLightElement.getAttribute('y')", "100");
+shouldBeEqualToString("spotLightElement.getAttribute('y')", "70");
function repaintTest() {
- spotLightElement.setAttribute("y", "0");
- shouldBeEqualToString("spotLightElement.getAttribute('y')", "0");
+ spotLightElement.setAttribute("y", "-30");
+ shouldBeEqualToString("spotLightElement.getAttribute('y')", "-30");
completeTest();
}

Powered by Google App Engine
This is Rietveld 408576698