LayoutTests/svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-y-attr.js - Issue 181943003: Scaling and offset fix for FELighting (software and skia paths)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-y-attr.js

Issue 181943003: Scaling and offset fix for FELighting (software and skia paths) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Changed fix to temporary light creation Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-x-attr.js ('k') | LayoutTests/svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-z-attr.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-y-attr.js

diff --git a/LayoutTests/svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-y-attr.js b/LayoutTests/svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-y-attr.js

index e78cddef8b98b717948ccf5df01c77dba80d72a1..c1257d37676de9522cf2e85b0f3f81a2690c6a5f 100644

--- a/LayoutTests/svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-y-attr.js

+++ b/LayoutTests/svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-y-attr.js

@@ -5,11 +5,11 @@ description("Tests dynamic updates of the 'y' attribute of the SVGFESpotLightEle

createSVGTestCase();

var spotLightElement = createSVGElement("feSpotLight");

-spotLightElement.setAttribute("x", "113");

-spotLightElement.setAttribute("y", "100");

+spotLightElement.setAttribute("x", "83");

+spotLightElement.setAttribute("y", "70");

spotLightElement.setAttribute("z", "100");

-spotLightElement.setAttribute("pointsAtX", "113");

-spotLightElement.setAttribute("pointsAtY", "100");

+spotLightElement.setAttribute("pointsAtX", "83");

+spotLightElement.setAttribute("pointsAtY", "70");

spotLightElement.setAttribute("pointsAtZ", "0");

spotLightElement.setAttribute("specularExponent", "1");

spotLightElement.setAttribute("limitingConeAngle", "15");

@@ -38,11 +38,11 @@ rectElement.setAttribute("height", "200");

rectElement.setAttribute("filter", "url(#myFilter)");

rootSVGElement.appendChild(rectElement);

-shouldBeEqualToString("spotLightElement.getAttribute('y')", "100");

+shouldBeEqualToString("spotLightElement.getAttribute('y')", "70");

function repaintTest() {

- spotLightElement.setAttribute("y", "0");

- shouldBeEqualToString("spotLightElement.getAttribute('y')", "0");

+ spotLightElement.setAttribute("y", "-30");

+ shouldBeEqualToString("spotLightElement.getAttribute('y')", "-30");

completeTest();

}