Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: third_party/WebKit/Source/modules/webgl/WebGLProgram.cpp

Issue 1808403002: Move simple methods [F-S] from WebGraphicsContext3D to GLES2Interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bindFoo
Patch Set: simples-fplus: tests Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #include "modules/webgl/WebGLProgram.h" 26 #include "modules/webgl/WebGLProgram.h"
27 27
28 #include "gpu/command_buffer/client/gles2_interface.h"
28 #include "modules/webgl/WebGLContextGroup.h" 29 #include "modules/webgl/WebGLContextGroup.h"
29 #include "modules/webgl/WebGLRenderingContextBase.h" 30 #include "modules/webgl/WebGLRenderingContextBase.h"
30 31
31 namespace blink { 32 namespace blink {
32 33
33 WebGLProgram* WebGLProgram::create(WebGLRenderingContextBase* ctx) 34 WebGLProgram* WebGLProgram::create(WebGLRenderingContextBase* ctx)
34 { 35 {
35 return new WebGLProgram(ctx); 36 return new WebGLProgram(ctx);
36 } 37 }
37 38
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 case GL_FRAGMENT_SHADER: 164 case GL_FRAGMENT_SHADER:
164 if (m_fragmentShader != shader) 165 if (m_fragmentShader != shader)
165 return false; 166 return false;
166 m_fragmentShader = nullptr; 167 m_fragmentShader = nullptr;
167 return true; 168 return true;
168 default: 169 default:
169 return false; 170 return false;
170 } 171 }
171 } 172 }
172 173
173 void WebGLProgram::cacheActiveAttribLocations(WebGraphicsContext3D* context3d) 174 void WebGLProgram::cacheActiveAttribLocations(WebGraphicsContext3D* context3d, g pu::gles2::GLES2Interface* gl)
174 { 175 {
175 m_activeAttribLocations.clear(); 176 m_activeAttribLocations.clear();
176 177
177 GLint numAttribs = 0; 178 GLint numAttribs = 0;
178 context3d->getProgramiv(m_object, GL_ACTIVE_ATTRIBUTES, &numAttribs); 179 gl->GetProgramiv(m_object, GL_ACTIVE_ATTRIBUTES, &numAttribs);
179 m_activeAttribLocations.resize(static_cast<size_t>(numAttribs)); 180 m_activeAttribLocations.resize(static_cast<size_t>(numAttribs));
180 for (int i = 0; i < numAttribs; ++i) { 181 for (int i = 0; i < numAttribs; ++i) {
181 WebGraphicsContext3D::ActiveInfo info; 182 WebGraphicsContext3D::ActiveInfo info;
182 context3d->getActiveAttrib(m_object, i, info); 183 context3d->getActiveAttrib(m_object, i, info);
183 m_activeAttribLocations[i] = context3d->getAttribLocation(m_object, info .name.utf8().data()); 184 m_activeAttribLocations[i] = gl->GetAttribLocation(m_object, info.name.u tf8().data());
184 } 185 }
185 } 186 }
186 187
187 void WebGLProgram::cacheInfoIfNeeded() 188 void WebGLProgram::cacheInfoIfNeeded()
188 { 189 {
189 if (m_infoValid) 190 if (m_infoValid)
190 return; 191 return;
191 192
192 if (!m_object) 193 if (!m_object)
193 return; 194 return;
194 195
195 if (!contextGroup()) 196 if (!contextGroup())
196 return; 197 return;
197 WebGraphicsContext3D* context = contextGroup()->getAWebGraphicsContext3D(); 198 WebGraphicsContext3D* context = contextGroup()->getAWebGraphicsContext3D();
198 if (!context) 199 if (!context)
199 return; 200 return;
201 gpu::gles2::GLES2Interface* gl = context->getGLES2Interface();
200 GLint linkStatus = 0; 202 GLint linkStatus = 0;
201 context->getProgramiv(m_object, GL_LINK_STATUS, &linkStatus); 203 gl->GetProgramiv(m_object, GL_LINK_STATUS, &linkStatus);
202 m_linkStatus = linkStatus; 204 m_linkStatus = linkStatus;
203 if (m_linkStatus) 205 if (m_linkStatus)
204 cacheActiveAttribLocations(context); 206 cacheActiveAttribLocations(context, gl);
205 m_infoValid = true; 207 m_infoValid = true;
206 } 208 }
207 209
208 DEFINE_TRACE(WebGLProgram) 210 DEFINE_TRACE(WebGLProgram)
209 { 211 {
210 visitor->trace(m_vertexShader); 212 visitor->trace(m_vertexShader);
211 visitor->trace(m_fragmentShader); 213 visitor->trace(m_fragmentShader);
212 WebGLSharedPlatform3DObject::trace(visitor); 214 WebGLSharedPlatform3DObject::trace(visitor);
213 } 215 }
214 216
215 } // namespace blink 217 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGLProgram.h ('k') | third_party/WebKit/Source/modules/webgl/WebGLQuery.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698