Move simple methods [A-E] from WebGraphicsContext3D to GLES2Interface.

Move simple methods [A-E] from WebGraphicsContext3D to GLES2Interface.

This removes methods from WebGraphicsContext3D that were simple macro-
based pass-throughs to the underlying GLES2Interface, and changes
callers in blink to use the GLES2Interface for them instead.

R=junov@chromium.org, kbr@chromium.org, piman, chrishtr
TBR=pfeldman, kbr
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/611de09a17728eb0c1713b30ab3c2178a106d146
Cr-Commit-Position: refs/heads/master@{#382081}

[danakj, 2016-03-17 00:48:36]

Description was changed from

==========
Move simple methods [A-E] from WebGraphicsContext3D to GLES2Interface.

This removes methods from WebGraphicsContext3D that were simple macro-
based pass-throughs to the underlying GLES2Interface, and changes
callers in blink to use the GLES2Interface for them instead.

R=junov@chromium.org, kbr@chromium.org
BUG=584497
==========

to

==========
Move simple methods [A-E] from WebGraphicsContext3D to GLES2Interface.

This removes methods from WebGraphicsContext3D that were simple macro-
based pass-throughs to the underlying GLES2Interface, and changes
callers in blink to use the GLES2Interface for them instead.

R=junov@chromium.org, kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[danakj, 2016-03-17 00:51:27]

Patchset #1 (id:1) has been deleted

[Justin Novosad, 2016-03-17 19:57:00]

The mix of WGC3D and GLES2Interface is discomforting, I assume this is a
transitional state. Eventually, it will be just GLES2Interface everywhere,
right?

[danakj, 2016-03-17 19:59:29]

On Thu, Mar 17, 2016 at 12:57 PM, <junov@chromium.org> wrote:

> The mix of WGC3D and GLES2Interface is discomforting, I assume this is a
> transitional state. Eventually, it will be just GLES2Interface everywhere,
> right?
>

Yep, I'll keep going till it's all GLES2Interface. I don't think it's
reasonable to review a patch that moves everything at once.


>
> https://codereview.chromium.org/1807103002/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[danakj, 2016-03-17 19:59:30]

On Thu, Mar 17, 2016 at 12:57 PM, <junov@chromium.org> wrote:

> The mix of WGC3D and GLES2Interface is discomforting, I assume this is a
> transitional state. Eventually, it will be just GLES2Interface everywhere,
> right?
>

Yep, I'll keep going till it's all GLES2Interface. I don't think it's
reasonable to review a patch that moves everything at once.


>
> https://codereview.chromium.org/1807103002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Justin Novosad, 2016-03-17 19:59:59]

platform/graphics lgtm

[danakj, 2016-03-17 21:23:03]

danakj@chromium.org changed reviewers:
+ sievers@chromium.org

[danakj, 2016-03-17 21:23:04]

+sievers for third_party/WebKit/Source/modules/webgl/ and gpu/

[danakj, 2016-03-17 23:27:57]

Found out we have a gl_helper_benchmark, updated it like gl_helper_unittest to
use an inprocess context directly and no Web*.

[piman, 2016-03-17 23:32:57]

piman@chromium.org changed reviewers:
+ piman@chromium.org

[piman, 2016-03-17 23:32:58]

lgtm

[danakj, 2016-03-17 23:34:50]

danakj@chromium.org changed reviewers:
+ chrishtr@chromium.org, pfeldman@chromium.org

[danakj, 2016-03-17 23:34:50]

+chrishtr for public/ and modules/ owners.
+pfeldman for test_runner/

[chrishtr, 2016-03-18 00:08:27]

lgtm

[danakj, 2016-03-18 00:10:26]

Description was changed from

==========
Move simple methods [A-E] from WebGraphicsContext3D to GLES2Interface.

This removes methods from WebGraphicsContext3D that were simple macro-
based pass-throughs to the underlying GLES2Interface, and changes
callers in blink to use the GLES2Interface for them instead.

R=junov@chromium.org, kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Move simple methods [A-E] from WebGraphicsContext3D to GLES2Interface.

This removes methods from WebGraphicsContext3D that were simple macro-
based pass-throughs to the underlying GLES2Interface, and changes
callers in blink to use the GLES2Interface for them instead.

R=junov@chromium.org, kbr@chromium.org, piman, chrishtr
TBR=pfeldman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[danakj, 2016-03-18 00:10:32]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-03-18 00:10:32]

The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1807103002/#ps100001
(title: "bindFoo: mac")

[commit-bot: I haz the power, 2016-03-18 00:11:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1807103002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1807103002/100001

[commit-bot: I haz the power, 2016-03-18 00:35:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 00:35:58]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[danakj, 2016-03-18 00:43:11]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-03-18 00:43:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org, junov@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1807103002/#ps120001
(title: "bindFoo: CheckFramebufferStatus")

[danakj, 2016-03-18 00:43:26]

The MockWGC3D::CheckFramebufferStatus function returned GL_FRAMEBUFFER_COMPLETE,
but the GLES2InterfaceStub returned 0. Override the method in DrawingBufferTests
to get the old behaviour.

[commit-bot: I haz the power, 2016-03-18 00:43:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1807103002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1807103002/120001

[commit-bot: I haz the power, 2016-03-18 00:47:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 00:47:33]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[danakj, 2016-03-18 17:40:44]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-03-18 17:41:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1807103002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1807103002/120001

[danakj, 2016-03-18 18:10:21]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-03-18 18:10:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org, junov@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1807103002/#ps140001
(title: "bindFoo: moretests")

[danakj, 2016-03-18 18:10:23]

Description was changed from

==========
Move simple methods [A-E] from WebGraphicsContext3D to GLES2Interface.

This removes methods from WebGraphicsContext3D that were simple macro-
based pass-throughs to the underlying GLES2Interface, and changes
callers in blink to use the GLES2Interface for them instead.

R=junov@chromium.org, kbr@chromium.org, piman, chrishtr
TBR=pfeldman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Move simple methods [A-E] from WebGraphicsContext3D to GLES2Interface.

This removes methods from WebGraphicsContext3D that were simple macro-
based pass-throughs to the underlying GLES2Interface, and changes
callers in blink to use the GLES2Interface for them instead.

R=junov@chromium.org, kbr@chromium.org, piman, chrishtr
TBR=pfeldman, kbr
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-03-18 18:10:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1807103002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1807103002/140001

[danakj, 2016-03-18 18:19:47]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2016-03-18 18:25:16]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-03-18 18:25:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org, junov@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1807103002/#ps160001
(title: "bindFoo: ALLthetests")

[commit-bot: I haz the power, 2016-03-18 18:26:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1807103002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1807103002/160001

[commit-bot: I haz the power, 2016-03-18 20:54:21]

Description was changed from

==========
Move simple methods [A-E] from WebGraphicsContext3D to GLES2Interface.

This removes methods from WebGraphicsContext3D that were simple macro-
based pass-throughs to the underlying GLES2Interface, and changes
callers in blink to use the GLES2Interface for them instead.

R=junov@chromium.org, kbr@chromium.org, piman, chrishtr
TBR=pfeldman, kbr
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Move simple methods [A-E] from WebGraphicsContext3D to GLES2Interface.

This removes methods from WebGraphicsContext3D that were simple macro-
based pass-throughs to the underlying GLES2Interface, and changes
callers in blink to use the GLES2Interface for them instead.

R=junov@chromium.org, kbr@chromium.org, piman, chrishtr
TBR=pfeldman, kbr
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-03-18 20:54:23]

Committed patchset #8 (id:160001)

[commit-bot: I haz the power, 2016-03-18 20:55:56]

Description was changed from

==========
Move simple methods [A-E] from WebGraphicsContext3D to GLES2Interface.

This removes methods from WebGraphicsContext3D that were simple macro-
based pass-throughs to the underlying GLES2Interface, and changes
callers in blink to use the GLES2Interface for them instead.

R=junov@chromium.org, kbr@chromium.org, piman, chrishtr
TBR=pfeldman, kbr
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Move simple methods [A-E] from WebGraphicsContext3D to GLES2Interface.

This removes methods from WebGraphicsContext3D that were simple macro-
based pass-throughs to the underlying GLES2Interface, and changes
callers in blink to use the GLES2Interface for them instead.

R=junov@chromium.org, kbr@chromium.org, piman, chrishtr
TBR=pfeldman, kbr
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/611de09a17728eb0c1713b30ab3c2178a106d146
Cr-Commit-Position: refs/heads/master@{#382081}
==========

[commit-bot: I haz the power, 2016-03-18 20:55:57]

Patchset 8 (id:??) landed as
https://crrev.com/611de09a17728eb0c1713b30ab3c2178a106d146
Cr-Commit-Position: refs/heads/master@{#382081}