Change primordial pipes to ShellClient

Change primordial pipes to ShellClient

Changes shell client startup pipes to be ShellClient instead
of ShellClientFactory. This simplifies a lot of startup code.

Due to this change, apps must now take responsibility for
shutting themselves down when they feel it's appropriate. For
now, all relevant apps are force-exited to mimic the old
behavior.

Once apptests are deleted, we should expose a clean quit
closure to apps so they have something to run when they want
to quit. Hard-exiting the process is definitely not the right
thing to do.

BUG=

Committed: https://crrev.com/d5669c5cce5e182f29a4387807cda0c74e8265eb
Cr-Commit-Position: refs/heads/master@{#381114}

[Ken Rockot(use gerrit already), 2016-03-14 19:30:06]

rockot@chromium.org changed reviewers:
+ ben@chromium.org

[Ken Rockot(use gerrit already), 2016-03-14 19:30:07]

The main annoyance here is that everyone (tests mostly) was depending on
ChildProcess behavior to kill the current process on ShellClientFactory pipe
error. Since this pipe no longer exists, it calls on apps to do the right thing
on ShellClient error or whenever they deem it appropriate to quit themselves.

For now I've gone and implemented ShellConnectionLost in a bunch of places with
a dumb _exit(1). We should fix this, but I'd rather wait until we kill apptests
since they rely on this the most.

Lots of code delete though, so that's nice.

https://codereview.chromium.org/1801963002/diff/1/mojo/shell/shell.cc
File mojo/shell/shell.cc (right):

https://codereview.chromium.org/1801963002/diff/1/mojo/shell/shell.cc#newcode668
mojo/shell/shell.cc:668: if (client.is_bound()) {
Not crazy about how this logic panned out. We should be able to simplify at
least by getting rid of Loader.

[Ben Goodger (Google), 2016-03-14 21:09:58]

Uh-mazing.

lgtm

[Ken Rockot(use gerrit already), 2016-03-14 23:05:03]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-03-14 23:05:03]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org
Link to the patchset: https://codereview.chromium.org/1801963002/#ps100001
(title: "rebase onto catalog CL")

[commit-bot: I haz the power, 2016-03-14 23:05:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1801963002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1801963002/100001

[commit-bot: I haz the power, 2016-03-14 23:38:37]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-03-14 23:40:48]

Description was changed from

==========
Change primordial pipes to ShellClient

Changes shell client startup pipes to be ShellClient instead
of ShellClientFactory. This simplifies a lot of startup code.

Due to this change, apps must now take responsibility for
shutting themselves down when they feel it's appropriate. For
now, all relevant apps are force-exited to mimic the old
behavior.

Once apptests are deleted, we should expose a clean quit
closure to apps so they have something to run when they want
to quit. Hard-exiting the process is definitely not the right
thing to do.

BUG=
==========

to

==========
Change primordial pipes to ShellClient

Changes shell client startup pipes to be ShellClient instead
of ShellClientFactory. This simplifies a lot of startup code.

Due to this change, apps must now take responsibility for
shutting themselves down when they feel it's appropriate. For
now, all relevant apps are force-exited to mimic the old
behavior.

Once apptests are deleted, we should expose a clean quit
closure to apps so they have something to run when they want
to quit. Hard-exiting the process is definitely not the right
thing to do.

BUG=

Committed: https://crrev.com/d5669c5cce5e182f29a4387807cda0c74e8265eb
Cr-Commit-Position: refs/heads/master@{#381114}
==========

[commit-bot: I haz the power, 2016-03-14 23:40:50]

Patchset 6 (id:??) landed as
https://crrev.com/d5669c5cce5e182f29a4387807cda0c74e8265eb
Cr-Commit-Position: refs/heads/master@{#381114}