Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: mojo/shell/runner/host/in_process_native_runner.cc

Issue 1801963002: Change primordial pipes to ShellClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase onto catalog CL Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/shell/runner/host/in_process_native_runner.cc
diff --git a/mojo/shell/runner/host/in_process_native_runner.cc b/mojo/shell/runner/host/in_process_native_runner.cc
index c006a793b8e6798ae4962d78569194db44fca5d7..823cf5f3b45198ca3ae153f76feeb9fa4e9dc3b1 100644
--- a/mojo/shell/runner/host/in_process_native_runner.cc
+++ b/mojo/shell/runner/host/in_process_native_runner.cc
@@ -13,6 +13,7 @@
#include "base/task_runner.h"
#include "base/thread_task_runner_handle.h"
#include "base/threading/platform_thread.h"
+#include "mojo/public/cpp/bindings/interface_request.h"
#include "mojo/shell/runner/host/native_application_support.h"
#include "mojo/shell/runner/host/out_of_process_native_runner.h"
#include "mojo/shell/runner/init.h"
@@ -33,17 +34,17 @@ InProcessNativeRunner::~InProcessNativeRunner() {
}
}
-void InProcessNativeRunner::Start(
+mojom::ShellClientPtr InProcessNativeRunner::Start(
const base::FilePath& app_path,
const Identity& target,
bool start_sandboxed,
- mojom::ShellClientRequest request,
const base::Callback<void(base::ProcessId)>& pid_available_callback,
const base::Closure& app_completed_callback) {
app_path_ = app_path;
DCHECK(!request_.is_pending());
- request_ = std::move(request);
+ mojom::ShellClientPtr client;
+ request_ = GetProxy(&client);
DCHECK(app_completed_callback_runner_.is_null());
app_completed_callback_runner_ = base::Bind(
@@ -58,6 +59,8 @@ void InProcessNativeRunner::Start(
thread_.reset(new base::DelegateSimpleThread(this, thread_name));
thread_->Start();
pid_available_callback.Run(base::kNullProcessId);
+
+ return client;
}
void InProcessNativeRunner::Run() {
« no previous file with comments | « mojo/shell/runner/host/in_process_native_runner.h ('k') | mojo/shell/runner/host/out_of_process_native_runner.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698