Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Unified Diff: mojo/shell/public/cpp/shell_connection.h

Issue 1801963002: Change primordial pipes to ShellClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase onto catalog CL Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/shell/public/cpp/names.h ('k') | mojo/shell/public/interfaces/connector.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/public/cpp/shell_connection.h
diff --git a/mojo/shell/public/cpp/shell_connection.h b/mojo/shell/public/cpp/shell_connection.h
index 216ff932d87097cb1ee8fcc25ab03b4542ae3400..8c90ec7d016676f91579fcb2d34b89a0cb9cd333 100644
--- a/mojo/shell/public/cpp/shell_connection.h
+++ b/mojo/shell/public/cpp/shell_connection.h
@@ -43,15 +43,10 @@ class Connector;
//
class ShellConnection : public shell::mojom::ShellClient {
public:
- // Creates a new ShellConnection to eventually be bound to a
- // ShellClientRequest (see BindToRequest()). This connection may be used
- // immediately to begin making outgoing connections via connector().
- //
- // Does not take ownership of |client|, which must remain valid for the
- // lifetime of ShellConnection.
- explicit ShellConnection(mojo::ShellClient* client);
-
- // Like above but binds to |request| upon construction.
+ // Creates a new ShellConnection bound to |request|. This connection may be
+ // used immediately to make outgoing connections via connector(). Does not
+ // take ownership of |client|, which must remain valid for the lifetime of
+ // ShellConnection.
ShellConnection(mojo::ShellClient* client,
shell::mojom::ShellClientRequest request);
@@ -59,10 +54,6 @@ class ShellConnection : public shell::mojom::ShellClient {
Connector* connector() { return connector_.get(); }
- // Binds this ShellConnection to a client request if one was not available at
- // construction time.
- void BindToRequest(shell::mojom::ShellClientRequest request);
-
// TODO(rockot): Remove this once we get rid of app tests.
void SetAppTestConnectorForTesting(shell::mojom::ConnectorPtr connector);
« no previous file with comments | « mojo/shell/public/cpp/names.h ('k') | mojo/shell/public/interfaces/connector.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698