Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1791663002: Allow Catalogs to be constructed per-user (Closed)

Created:
4 years, 9 months ago by Ben Goodger (Google)
Modified:
4 years, 9 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@49catalog
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow Catalogs to be constructed per-user BUG= Committed: https://crrev.com/1693cacfdda556be0d56381104055f12829b6772 Cr-Commit-Position: refs/heads/master@{#381099}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -144 lines) Patch
M content/browser/mojo/mojo_shell_context.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/mojo_shell.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/catalog/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/catalog/catalog.h View 1 2 3 4 5 6 2 chunks +7 lines, -26 lines 0 comments Download
M mojo/services/catalog/catalog.cc View 1 2 3 4 5 6 5 chunks +22 lines, -17 lines 0 comments Download
A mojo/services/catalog/factory.h View 1 2 3 4 5 6 1 chunk +80 lines, -0 lines 0 comments Download
A mojo/services/catalog/factory.cc View 1 2 3 4 5 6 1 chunk +66 lines, -0 lines 0 comments Download
D mojo/services/catalog/owner.h View 1 chunk +0 lines, -44 lines 0 comments Download
D mojo/services/catalog/owner.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M mojo/shell/background/tests/test_service.cc View 1 2 3 4 5 6 2 chunks +6 lines, -1 line 0 comments Download
M mojo/shell/runner/host/native_application_support.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/shell.h View 1 2 3 4 5 2 chunks +2 lines, -3 lines 0 comments Download
M mojo/shell/shell.cc View 1 2 3 4 5 4 chunks +24 lines, -12 lines 0 comments Download
M mojo/shell/standalone/context.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/standalone/context.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/tests/loader_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Dependent Patchsets:

Issue 1801963002 Patch 100001

Messages

Total messages: 8 (3 generated)
Ben Goodger (Google)
4 years, 9 months ago (2016-03-13 04:17:10 UTC) #2
Ken Rockot(use gerrit already)
lgtm
4 years, 9 months ago (2016-03-14 21:57:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1791663002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1791663002/120001
4 years, 9 months ago (2016-03-14 22:07:53 UTC) #5
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 9 months ago (2016-03-14 22:48:58 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 22:50:36 UTC) #8
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/1693cacfdda556be0d56381104055f12829b6772
Cr-Commit-Position: refs/heads/master@{#381099}

Powered by Google App Engine
This is Rietveld 408576698