Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1905)

Unified Diff: mojo/shell/native_runner.h

Issue 1801963002: Change primordial pipes to ShellClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase onto catalog CL Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/mojo_shell.gyp ('k') | mojo/shell/public/cpp/application_runner.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/native_runner.h
diff --git a/mojo/shell/native_runner.h b/mojo/shell/native_runner.h
index 92c1adc1f4694d615b8f0785439fbeb723569835..bf287552d514bdab4e83be6df8273a6b0d62c0c4 100644
--- a/mojo/shell/native_runner.h
+++ b/mojo/shell/native_runner.h
@@ -10,7 +10,6 @@
#include "base/process/process_handle.h"
#include "mojo/public/cpp/bindings/interface_request.h"
#include "mojo/shell/public/interfaces/shell_client.mojom.h"
-#include "mojo/shell/public/interfaces/shell_client_factory.mojom.h"
namespace base {
class FilePath;
@@ -28,12 +27,12 @@ class NativeRunner {
virtual ~NativeRunner() {}
// Loads the app in the file at |app_path| and runs it on some other
- // thread/process.
- virtual void Start(
+ // thread/process. Returns a ShellClient handle the shell can use to connect
+ // to the the app.
+ virtual mojom::ShellClientPtr Start(
const base::FilePath& app_path,
const Identity& target,
bool start_sandboxed,
- InterfaceRequest<mojom::ShellClient> request,
const base::Callback<void(base::ProcessId)>& pid_available_callback,
const base::Closure& app_completed_callback) = 0;
};
« no previous file with comments | « mojo/mojo_shell.gyp ('k') | mojo/shell/public/cpp/application_runner.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698