Issue 1787453002: Switch "const StringPiece&" to just "StringPiece" in QUIC code. No functional change. Not flag prot…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1787453002: Switch "const StringPiece&" to just "StringPiece" in QUIC code. No functional change. Not flag prot… (Closed)

Created:
4 years, 9 months ago by rjshade

Modified:
4 years, 9 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, Jeremy Dorfman

Base URL:
https://chromium.googlesource.com/chromium/src.git@116566297

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Switch "const StringPiece&" to just "StringPiece" in QUIC code. No functional change. Not flag protected. Merge internal change: 116570346 R=rch@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : Remove const StringPiece& from _nss crypto files. #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -38 lines)			Patch
M	net/quic/crypto/aead_base_decrypter.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/quic/crypto/aead_base_decrypter_nss.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/quic/crypto/aead_base_decrypter_openssl.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/quic/crypto/aes_128_gcm_12_decrypter.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/crypto/aes_128_gcm_12_decrypter_nss.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/crypto/chacha20_poly1305_decrypter.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/crypto/chacha20_poly1305_decrypter_nss.cc	View	1	1 chunk	+4 lines, -5 lines	0 comments	Download
M	net/quic/crypto/curve25519_key_exchange.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/quic/crypto/curve25519_key_exchange.cc	View		2 chunks	+3 lines, -5 lines	0 comments	Download
M	net/quic/crypto/key_exchange.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/crypto/null_decrypter.h	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	net/quic/crypto/null_decrypter.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/quic/crypto/p256_key_exchange.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/crypto/p256_key_exchange_nss.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/crypto/p256_key_exchange_openssl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/crypto/quic_decrypter.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/quic/quic_connection_test.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/quic/quic_framer.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_framer_test.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Depends on Patchset:

Issue 1785863002 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages