Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: net/quic/crypto/p256_key_exchange_openssl.cc

Issue 1787453002: Switch "const StringPiece&" to just "StringPiece" in QUIC code. No functional change. Not flag prot… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@116566297
Patch Set: Remove const StringPiece& from _nss crypto files. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/crypto/p256_key_exchange_nss.cc ('k') | net/quic/crypto/quic_decrypter.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/crypto/p256_key_exchange.h" 5 #include "net/quic/crypto/p256_key_exchange.h"
6 6
7 #include <openssl/ec.h> 7 #include <openssl/ec.h>
8 #include <openssl/ecdh.h> 8 #include <openssl/ecdh.h>
9 #include <openssl/evp.h> 9 #include <openssl/evp.h>
10 10
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 } 70 }
71 return string(reinterpret_cast<char*>(private_key.get()), key_len); 71 return string(reinterpret_cast<char*>(private_key.get()), key_len);
72 } 72 }
73 73
74 KeyExchange* P256KeyExchange::NewKeyPair(QuicRandom* /*rand*/) const { 74 KeyExchange* P256KeyExchange::NewKeyPair(QuicRandom* /*rand*/) const {
75 // TODO(agl): avoid the serialisation/deserialisation in this function. 75 // TODO(agl): avoid the serialisation/deserialisation in this function.
76 const string private_value = NewPrivateKey(); 76 const string private_value = NewPrivateKey();
77 return P256KeyExchange::New(private_value); 77 return P256KeyExchange::New(private_value);
78 } 78 }
79 79
80 bool P256KeyExchange::CalculateSharedKey(const StringPiece& peer_public_value, 80 bool P256KeyExchange::CalculateSharedKey(StringPiece peer_public_value,
81 string* out_result) const { 81 string* out_result) const {
82 if (peer_public_value.size() != kUncompressedP256PointBytes) { 82 if (peer_public_value.size() != kUncompressedP256PointBytes) {
83 DVLOG(1) << "Peer public value is invalid"; 83 DVLOG(1) << "Peer public value is invalid";
84 return false; 84 return false;
85 } 85 }
86 86
87 crypto::ScopedEC_POINT point( 87 crypto::ScopedEC_POINT point(
88 EC_POINT_new(EC_KEY_get0_group(private_key_.get()))); 88 EC_POINT_new(EC_KEY_get0_group(private_key_.get())));
89 if (!point || 89 if (!point ||
90 !EC_POINT_oct2point(/* also test if point is on curve */ 90 !EC_POINT_oct2point(/* also test if point is on curve */
(...skipping 19 matching lines...) Expand all
110 StringPiece P256KeyExchange::public_value() const { 110 StringPiece P256KeyExchange::public_value() const {
111 return StringPiece(reinterpret_cast<const char*>(public_key_), 111 return StringPiece(reinterpret_cast<const char*>(public_key_),
112 sizeof(public_key_)); 112 sizeof(public_key_));
113 } 113 }
114 114
115 QuicTag P256KeyExchange::tag() const { 115 QuicTag P256KeyExchange::tag() const {
116 return kP256; 116 return kP256;
117 } 117 }
118 118
119 } // namespace net 119 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/crypto/p256_key_exchange_nss.cc ('k') | net/quic/crypto/quic_decrypter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698