net/quic/quic_framer.cc - Issue 1787453002: Switch "const StringPiece&" to just "StringPiece" in QUIC code. No functional change. Not flag prot…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_framer.cc

Issue 1787453002: Switch "const StringPiece&" to just "StringPiece" in QUIC code. No functional change. Not flag prot… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@116566297

Patch Set: Remove const StringPiece& from _nss crypto files. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_framer.cc

diff --git a/net/quic/quic_framer.cc b/net/quic/quic_framer.cc

index ec849f1cd81c834100be99515645a39eee523c16..fa667f24f504f567af33fa5e4965ce40efd7cd54 100644

--- a/net/quic/quic_framer.cc

+++ b/net/quic/quic_framer.cc

@@ -1702,7 +1702,7 @@ bool QuicFramer::DecryptPayload(QuicDataReader* encrypted_reader,

size_t* decrypted_length) {

StringPiece encrypted = encrypted_reader->ReadRemainingPayload();

DCHECK(decrypter_.get() != nullptr);

- const StringPiece& associated_data = GetAssociatedDataFromEncryptedPacket(

+ StringPiece associated_data = GetAssociatedDataFromEncryptedPacket(

packet, header.public_header.connection_id_length,

header.public_header.version_flag, header.public_header.multipath_flag,

header.public_header.packet_number_length);

« no previous file with comments | « net/quic/quic_connection_test.cc ('k') | net/quic/quic_framer_test.cc » ('j') | no next file with comments »