net/quic/crypto/p256_key_exchange_openssl.cc - Issue 1787453002: Switch "const StringPiece&" to just "StringPiece" in QUIC code. No functional change. Not flag prot…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/crypto/p256_key_exchange_openssl.cc

Issue 1787453002: Switch "const StringPiece&" to just "StringPiece" in QUIC code. No functional change. Not flag prot… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@116566297

Patch Set: Remove const StringPiece& from _nss crypto files. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/crypto/p256_key_exchange_openssl.cc

diff --git a/net/quic/crypto/p256_key_exchange_openssl.cc b/net/quic/crypto/p256_key_exchange_openssl.cc

index 7a9707e308d1a09483d5cfae8c0f6e3e0bb27701..9703a2e9f64235c20c0f970f5d23135ef7bbf2f7 100644

--- a/net/quic/crypto/p256_key_exchange_openssl.cc

+++ b/net/quic/crypto/p256_key_exchange_openssl.cc

@@ -77,7 +77,7 @@ KeyExchange* P256KeyExchange::NewKeyPair(QuicRandom* /*rand*/) const {

return P256KeyExchange::New(private_value);

}

-bool P256KeyExchange::CalculateSharedKey(const StringPiece& peer_public_value,

+bool P256KeyExchange::CalculateSharedKey(StringPiece peer_public_value,

string* out_result) const {

if (peer_public_value.size() != kUncompressedP256PointBytes) {

DVLOG(1) << "Peer public value is invalid";

« no previous file with comments | « net/quic/crypto/p256_key_exchange_nss.cc ('k') | net/quic/crypto/quic_decrypter.h » ('j') | no next file with comments »