net/quic/crypto/p256_key_exchange.h - Issue 1787453002: Switch "const StringPiece&" to just "StringPiece" in QUIC code. No functional change. Not flag prot…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/crypto/p256_key_exchange.h

Issue 1787453002: Switch "const StringPiece&" to just "StringPiece" in QUIC code. No functional change. Not flag prot… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@116566297

Patch Set: Remove const StringPiece& from _nss crypto files. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/crypto/p256_key_exchange.h

diff --git a/net/quic/crypto/p256_key_exchange.h b/net/quic/crypto/p256_key_exchange.h

index e6855aa31a5b5f8af2cbc713d2ae90f39293a990..197adfe557c53d4d4cd90bee647e0a40af5b5326 100644

--- a/net/quic/crypto/p256_key_exchange.h

+++ b/net/quic/crypto/p256_key_exchange.h

@@ -42,7 +42,7 @@ class NET_EXPORT_PRIVATE P256KeyExchange : public KeyExchange {

// KeyExchange interface.

KeyExchange* NewKeyPair(QuicRandom* rand) const override;

- bool CalculateSharedKey(const base::StringPiece& peer_public_value,

+ bool CalculateSharedKey(base::StringPiece peer_public_value,

std::string* shared_key) const override;

base::StringPiece public_value() const override;

QuicTag tag() const override;

« no previous file with comments | « net/quic/crypto/null_decrypter.cc ('k') | net/quic/crypto/p256_key_exchange_nss.cc » ('j') | no next file with comments »