Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Unified Diff: net/quic/crypto/curve25519_key_exchange.h

Issue 1787453002: Switch "const StringPiece&" to just "StringPiece" in QUIC code. No functional change. Not flag prot… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@116566297
Patch Set: Remove const StringPiece& from _nss crypto files. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/crypto/chacha20_poly1305_decrypter_nss.cc ('k') | net/quic/crypto/curve25519_key_exchange.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/crypto/curve25519_key_exchange.h
diff --git a/net/quic/crypto/curve25519_key_exchange.h b/net/quic/crypto/curve25519_key_exchange.h
index 1637bbb481de1145c9d4294b6044cb63aac2e92d..a95cf7f6ce6d063193e3d2912aaaf6fff06c3708 100644
--- a/net/quic/crypto/curve25519_key_exchange.h
+++ b/net/quic/crypto/curve25519_key_exchange.h
@@ -26,7 +26,7 @@ class NET_EXPORT_PRIVATE Curve25519KeyExchange : public KeyExchange {
// New creates a new object from a private key. If the private key is
// invalid, nullptr is returned.
- static Curve25519KeyExchange* New(const base::StringPiece& private_key);
+ static Curve25519KeyExchange* New(base::StringPiece private_key);
// NewPrivateKey returns a private key, generated from |rand|, suitable for
// passing to |New|.
@@ -34,7 +34,7 @@ class NET_EXPORT_PRIVATE Curve25519KeyExchange : public KeyExchange {
// KeyExchange interface.
KeyExchange* NewKeyPair(QuicRandom* rand) const override;
- bool CalculateSharedKey(const base::StringPiece& peer_public_value,
+ bool CalculateSharedKey(base::StringPiece peer_public_value,
std::string* shared_key) const override;
base::StringPiece public_value() const override;
QuicTag tag() const override;
« no previous file with comments | « net/quic/crypto/chacha20_poly1305_decrypter_nss.cc ('k') | net/quic/crypto/curve25519_key_exchange.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698