net/quic/quic_framer_test.cc - Issue 1787453002: Switch "const StringPiece&" to just "StringPiece" in QUIC code. No functional change. Not flag prot…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_framer_test.cc

Issue 1787453002: Switch "const StringPiece&" to just "StringPiece" in QUIC code. No functional change. Not flag prot… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@116566297

Patch Set: Remove const StringPiece& from _nss crypto files. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_framer_test.cc

diff --git a/net/quic/quic_framer_test.cc b/net/quic/quic_framer_test.cc

index ac4a39c289002a3df14f809da347bcd2628f6a58..d770db9da04914a8b486c6f987ce2bb0eeb0d17b 100644

--- a/net/quic/quic_framer_test.cc

+++ b/net/quic/quic_framer_test.cc

@@ -154,8 +154,8 @@ class TestDecrypter : public QuicDecrypter {

bool SetNoncePrefix(StringPiece nonce_prefix) override { return true; }

bool DecryptPacket(QuicPathId path_id,

QuicPacketNumber packet_number,

- const StringPiece& associated_data,

- const StringPiece& ciphertext,

+ StringPiece associated_data,

+ StringPiece ciphertext,

char* output,

size_t* output_length,

size_t max_output_length) override {

« no previous file with comments | « net/quic/quic_framer.cc ('k') | no next file » | no next file with comments »